Fix in preselection of low pt muon mva (muon POG)

[sscruz]

PR description:

Bugfix in preselection for low pt lepton MVA. The preselection for the low pt lepton mva is buggy, as it includes additional isolation and IP cuts. The bug affects only the selection decision, and not the MVA value, as it is always calculated regardless of the preselection.

@Fedespring @bmahakud

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26723/9709

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @sscruz for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/120/console Started: 2019/05/09 12:47

[cmsbuild]

+1
Tested at: 1289feb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-860799/120/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-860799/120/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

@sscruz
I see that the comments in the code are pointing to https://twiki.cern.ch/twiki/bin/viewauth/CMS/LeptonMVA
Please make sure that this is updated with the details relevant for the low-pt MVA so that we keep the documentation current
Thank you.

[slava77]

+1

for #26723 1289feb

• code changes are in line with the PR description. The changes are rather straightforward; however, the reference documentation (outside of CMSSW) should be updated to describe the selections.
• jenkins tests pass and comparisons with the baseline show differences only in the miniAOD slimmedMuons selectors variable, reflecting the changes in the selector flag definitions.

[sscruz]

@sscruz
I see that the comments in the code are pointing to https://twiki.cern.ch/twiki/bin/viewauth/CMS/LeptonMVA
Please make sure that this is updated with the details relevant for the low-pt MVA so that we keep the documentation current
Thank you.

@slava77 thanks a lot for realizing this. I have added the description of the low pt version in the twiki

[fabiocos]

+1

[fabiocos]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.