Utilities/General: Replace invalid XML characters in test/BuildFile.xml #26730
Conversation
In test/BuildFile.xml replace the invalid characters && with proper &&
|
The code-checks are being triggered in jenkins. |
|
please test |
Utilities/General/test/BuildFile.xml
Outdated
| @@ -12,5 +12,5 @@ | |||
| <iftool name="cuda-gcc-support"> | |||
| <test name="CudaGCCSupport" command="echo Supported GCC version"/> | |||
| <else/> | |||
| <test name="CudaGCCSupport" command="echo ERROR: Unsupported GCC version && exit 1"/> | |||
| <test name="CudaGCCSupport" command="echo ERROR: Unsupported GCC version && exit 1"/> | |||
There was a problem hiding this comment.
@gartung , please please && with ;
This is a shell command and echo ERROR: Unsupported GCC version && exit 1 will fail
Utilities/General/test/BuildFile.xml
Outdated
| @@ -12,5 +12,5 @@ | |||
| <iftool name="cuda-gcc-support"> | |||
| <test name="CudaGCCSupport" command="echo Supported GCC version"/> | |||
| <else/> | |||
| <test name="CudaGCCSupport" command="echo ERROR: Unsupported GCC version && exit 1"/> | |||
| <test name="CudaGCCSupport" command="echo ERROR: Unsupported GCC version && exit 1"/> | |||
There was a problem hiding this comment.
| <test name="CudaGCCSupport" command="echo ERROR: Unsupported GCC version && exit 1"/> | |
| <test name="CudaGCCSupport" command="echo ERROR: Unsupported GCC version ; exit 1"/> |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26730/9719
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: Utilities/General @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cmsbuild
added
code-checks-pending
tests-started
and removed
code-checks-approved
tests-pending
labels
|
I ran 'scram b test' in that directory but nothing happended possibly because I was using a FWLITE project area. |
|
@Dr15Jones please abort current test and restart test |
|
abort test |
|
@cmsbot please abort |
|
Jenkins tests are aborted. |
|
@cmsbot please test |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26730/9731
|
|
@smuzaffar why this sudden code-checks? Another problem with timestamps somewhere? |
|
Yes looked like timestamp issue or something like that. 19 hours ago bot reset the |
|
+1 |
In test/BuildFile.xml replace the invalid characters && with proper &&