PPS: bugfix in proton reconstruction.

[jan-kaspar]

PR description:

This PR fixes two problems observed in rare conditions:

• Fixed logic condition in CTPPSInterpolatedOpticalFunctionsESSource - the aim is to check the freshly-obtained xangle value, not the buffered one.
• In CTPPSProtonProducer, the re-initialisation is triggered with the help of an ESWatcher. With the recently introduced !hTracks->empty() condition, not all xangle transitions are seen anymore. Using ESWatcher is better anyway - the decision on updating optics-related data is made just on one place.

The fix is important for the UL re-reco. We apologise for the late submission.

PR validation:

Comparison on selected datasets, below, shows no difference wrt. the current master: blue = with this PR, red dashed = before this PR.

The problems addressed in this PR were discovered in a systematic test applied to (almost) all fills in which PPS Roman Pots participated (2016 to 2018). The problems occurred in about 5 out of 400 tests. After the fix all tests pass successfully. For the record, some of the originally failing input files were copied here:

• /afs/cern.ch/user/j/jkaspar/public/ctpps/proton_reco_debug/fill5405_xangle140_beta0.30_ZeroBias.root
• /afs/cern.ch/user/j/jkaspar/public/ctpps/proton_reco_debug/fill6960_xangle130_beta0.30_SingleMuon.root

These files are skims from the "official" AOD ntuples.

Finally, AddOnTests were run on LXPLUS, yielding: 46 tests passed, 1 failed. The failing test was running PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py and the failure was due to an XROOT problem.

[jan-kaspar]

FYI @fabferro

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26739/9729

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

CalibPPS/ESProducers
RecoCTPPS/ProtonReconstruction

@perrotta, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@forthommel, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

@fabiocos this is another item for #26721

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/144/console Started: 2019/05/10 15:15

[cmsbuild]

+1
Tested at: 18d740c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d00d41/144/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d00d41/144/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-d00d41/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 133
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211627
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #26739 18d740c

• code changes are in line with the PR description. The code changes affect only jobs with IOV transitions in PPS.
• jenkins tests pass and comparisons with the baseline show no differences
  • ignoring random changes in DT monitoring plots with nans

[fabiocos]

@tocheng @christopheralanwest @pohsun could you please have a look?

[christopheralanwest]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1