Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NanoAOD developments: 190520 version, part 2 for UL [106X] #26845

Merged

Conversation

peruzzim
Copy link
Contributor

@peruzzim peruzzim commented May 20, 2019

backport of #26844

Warning: this PR includes #26786 - a conflict with the HEAD of that PR is fixed here
Depends on #26847, and cms-sw/cmsdist#4996

Sam-Harper and others added 30 commits May 13, 2019 07:59
@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) #26847,cms-sw/cmsdist#4996
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/416/console Started: 2019/05/22 14:13

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b79bfb/416/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1123 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 92
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 3211569
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 25.727 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 25.727 KiB Physics/NanoAODDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@peruzzim
Copy link
Contributor Author

+xpog

sorry I had forgotten to sign also this backport

@perrotta
Copy link
Contributor

+1

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

+1

@cmsbuild cmsbuild merged commit 37397d4 into cms-sw:CMSSW_10_6_X Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet