Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop dqm 710pre2 v02 #2685

Merged
merged 42 commits into from
Mar 19, 2014

Conversation

sordini
Copy link
Contributor

@sordini sordini commented Mar 1, 2014

Some restructuring of DQMOffline/JetMET code. Also, the changes needed for threaded DQM are included. All changes have been developed and tested in CMSSW_7_1_0_pre2.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2014

A new Pull Request was created by @sordini for CMSSW_7_1_X.

Develop dqm 710pre2 v02

It involves the following packages:

DQMOffline/JetMET

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@nclopezo
Copy link
Contributor

nclopezo commented Mar 3, 2014

Hi @sordini,

This pull request is unmergeable, could you please rebase it? you can find instructions about unmergeable branches here:

http://cms-sw.github.io/cmssw/tutorial-forward-port.html

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
…ing of modules which clashed when running together with validation sequence in the matrix, first version of HI config files adapted to new system, update DataCertification to new naming scheme
@webermat
Copy link
Contributor

The consumes call should be fixed, the second problem concerning running on cosmics should be done too. While running the matrix at some point it complained about our Heavy Iron config file, so I decided to submit a first version which adapts the changed structure.
At some point a workflow complained that our JetMET validation sequence and our JetMET DQM sequence use the same naming convention for modules, so that is fixed as well.

@cmsbuild
Copy link
Contributor

Pull request #2685 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 17, 2014

hello @webermat
I still see that the HI workflow doesn't work because of a missing collection. have a look at:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2685/535/DQMTestsResults/DQMTestsResults/12/p12.1.log

do you think you can fix this one also?
thanks,
F.

@cmsbuild
Copy link
Contributor

Pull request #2685 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 19, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 19, 2014
DQMOffline/JetMET -- Develop dqm 710pre2 v02
@nclopezo nclopezo merged commit bd46d1f into cms-sw:CMSSW_7_1_X Mar 19, 2014
@slava77 slava77 mentioned this pull request May 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants