New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maskCell() bug fix: two masks were swapped #26877
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26877/9912
|
A new Pull Request was created by @b-fontana for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@bsunanda FYI |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@b-fontana @kpedro88 is this fix relevant for the forthcoming L1T TDR production? |
@fabiocos No, it is not. |
+1 |
PR description:
A bug was found in the cell masks that will be eventually used to mask some of the virtual wafers (the masks allow the implementation of partial wafers, such as "fives" or "threes"). Two masks were swapped.
PR validation:
The new masks were tested using RecHits from a particle gun: before correcting the bug and after correcting the bug. The wafers (2,2) and (-2,-2) were not being correctly masked.