-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Photos options (9_4_X) #26880
Conversation
A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_9_4_X. It involves the following packages: GeneratorInterface/PhotosInterface @alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@intrepid42 Why 94X instead of 93X? |
I think it's used for 5 TeV and low PU? Will create 93X and 71X* as well! * 71X seems to require Photos update... |
@intrepid42 ok, I see. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@intrepid42 @efeyazgan do we have production requests in 9_4_X requiring this PR? |
Hi Fabio, not yet, maybe in a couple of months. |
+1 |
PR description:
Backport of #26853