Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Photos options (9_4_X) #26880

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Conversation

mseidel42
Copy link
Contributor

PR description:

Backport of #26853

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_9_4_X.

It involves the following packages:

GeneratorInterface/PhotosInterface

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented May 22, 2019

@intrepid42 Why 94X instead of 93X?

@mseidel42
Copy link
Contributor Author

I think it's used for 5 TeV and low PU? Will create 93X and 71X* as well!

* 71X seems to require Photos update...

@qliphy
Copy link
Contributor

qliphy commented May 22, 2019

@intrepid42 ok, I see.

@qliphy
Copy link
Contributor

qliphy commented May 22, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/411/console Started: 2019/05/22 11:18

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e23fa0/411/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 115
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721216
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@efeyazgan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@intrepid42 @efeyazgan do we have production requests in 9_4_X requiring this PR?

@mseidel42
Copy link
Contributor Author

Hi Fabio, not yet, maybe in a couple of months.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 81228c3 into cms-sw:CMSSW_9_4_X Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants