Primitive RPC trigger #26967

maseguracern · 2019-05-28T13:23:36Z

This is the first version of the RPCTriggerPrimitives for the RPC detector. Which uses as an input the RPCDigis as an input and the RPCRecHits (New collection) as an output. The output of this module is an edm branch named RPCPrimitivesDigis, following the RPCRecHit format already committed in CMSSW_10_6_0. We apply the cluster size cut and emulate max two clusters per link board. The module can be tuned by the parameters LinkBoardCut and ClusterSizeCut for phaseII.

People interested: @maseguracern @BrieucF @abrinke1

cmsbuild · 2019-05-28T13:24:12Z

The code-checks are being triggered in jenkins.

Needed by: cms-sw/cmssw#26967

cmsbuild · 2019-05-28T14:01:38Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26967/10022

This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26967/10022/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26967/10022/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

cmsbuild · 2019-05-28T16:35:06Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-05-28T16:41:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26967/10026

This PR adds an extra 36KB to repository

cmsbuild · 2019-05-28T16:42:19Z

A new Pull Request was created by @maseguracern for master.

It involves the following packages:

L1Trigger/RPCTriggerPrimitives

The following packages do not have a category, yet:

L1Trigger/RPCTriggerPrimitives
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2019-05-29T02:18:27Z

assign l1

cmsbuild · 2019-05-29T02:18:58Z

New categories assigned: l1

@rekovic you have been requested to review this Pull request/Issue and eventually sign? Thanks

maseguracern · 2019-05-29T14:21:13Z

Yes, +1

rekovic · 2019-05-30T13:21:28Z

please test

cmsbuild · 2019-05-30T13:21:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/605/console Started: 2019/05/30 15:23

cmsbuild · 2019-07-04T13:55:45Z

Pull request #26967 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again.

fabiocos · 2019-07-04T14:32:59Z

please test

cmsbuild · 2019-07-04T14:33:30Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1328/console Started: 2019/07/04 16:34

cmsbuild · 2019-07-04T16:57:49Z

+1
Tested at: 5dc9b16
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96a93f/1328/summary.html

cmsbuild · 2019-07-04T16:57:52Z

Comparison job queued.

cmsbuild · 2019-07-04T19:22:02Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96a93f/1328/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3160399
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3160064
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

fabiocos · 2019-07-05T08:11:51Z

@rekovic I am satisfied, please check and in case sign it or comment further

rekovic · 2019-07-09T13:39:17Z

+1

cmsbuild · 2019-07-09T13:39:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-07-09T19:00:40Z

+1

Dr15Jones · 2019-07-10T18:24:17Z

L1Trigger/RPCTriggerPrimitives/python/primitiveRPCProducer_cfi.py

+    				deadSource = cms.string('File'),
+				deadvecfile = cms.FileInPath('RecoLocalMuon/RPCRecHit/data/RPCDeadVec.dat'),
+				recAlgoConfig = cms.PSet(),
+				recAlgo = cms.string('RPCRecHitStandardAlgo')	


The plugin named RPCRecHitStandardAlgo is not in CMSSW and is causing large number of workflows in the integration builds to fail.

It actually does exist, but is associated to a different plugin factory.

Dr15Jones · 2019-07-10T18:34:19Z

L1Trigger/RPCTriggerPrimitives/plugins/PrimitiveAlgoFactory.cc

+#include "FWCore/PluginManager/interface/PluginFactory.h"
+#include "L1Trigger/RPCTriggerPrimitives/plugins/PrimitiveAlgoFactory.h"
+
+EDM_REGISTER_PLUGINFACTORY(PrimitiveAlgoFactory, "PrimitiveAlgoFactory");


This is a big problem. The exact same Factory is already registered under a different name:

cmssw/RecoLocalMuon/RPCRecHit/interface/RPCRecHitAlgoFactory.h

Line 13 in 04a8594

typedef edmplugin::PluginFactory<RPCRecHitBaseAlgo *(const edm::ParameterSet &)> RPCRecHitAlgoFactory;

One cannot registered two factories with identically signatures under two different names. Only one name will be used by the system which leads to problems loading the plugins.

This factory declaration should go away and the code should just use the existing RPCRecHitAlgoFactory.

Unfortunately, I have problems by calling the rechitalgofactory, Does anyone know how can I solve?
L1TMuonRPCTriggerPrimitivesProducer.cc:(.text+0x28e): undefined reference to `edmplugin::PluginFactory<RPCRecHitBaseAlgo* (edm::ParameterSet const&)>::get()'

Do you have

<use name="RecoLocalMuon/RPCRecHit">

to your BuildFile.xml?

Yes I do, but it does not work.

The problem is the package RecoLocalMuon/RPCRecHit creates a plugin not a library and a plugin. Therefore you can't link to it and get the symbol you need. So it looks like files within RecoLocalMuon/RPCRecHit needs to be moved around so that at least RecoLocalMuon/RPCRecHit/src/RPCRecHitAlgoFactory.cc gets compiled into a library which is shared between the two packages.

those changes generate similar errors.
tmp/slc7_amd64_gcc700/src/RecoLocalMuon/RPCRecHit/src/RecoLocalMuonRPCRecHit/RPCRecHitBaseAlgo.cc.o: In function RPCRecHitBaseAlgo::reconstruct(RPCRoll const&, RPCDetId const&, std::pair<__gnu_cxx::__normal_iterator<RPCDigi const*, std::vector<RPCDigi, std::allocator<RPCDigi> > >, __gnu_cxx::__normal_iterator<RPCDigi const*, std::vector<RPCDigi, std::allocator<RPCDigi> > > > const&, std::bitset<192ul> const&)': RPCRecHitBaseAlgo.cc:(.text+0x71): undefined reference to RPCClusterizer::doAction(std::pair<__gnu_cxx::__normal_iterator<RPCDigi const*, std::vector<RPCDigi, std::allocator > >, __gnu_cxx::__normal_iterator<RPCDigi const*, std::vector<RPCDigi, std::allocator > > > const&)'

Wasn't RPCRecHitStandardAlgo.cc one of the files to move out of src/ and into plugins/ ?

Indeed, StandardAlgo is now in plugins

Can you point us to your code?

@smuzaffar any ideas?

/afs/cern.ch/user/m/masegura/CMSSW_10_6_0/src/RecoLocalMuon/RPCRecHit

fabiocos · 2019-07-10T19:47:31Z

@Dr15Jones this is indeed a problem, thanks for your comments. Anyway @smuzaffar I wonder why this did not cause troubles neither in local PR tests nor in CMSSW_11_0_X_2019-07-09-2300, as it was merged earlier than yesterday evening IB

maseguracern added 2 commits May 27, 2019 20:27

Trigger primitive phase2 @maseguracern

b7b93cc

Trigger primitive phase2 @maseguracern

59880cf

cmsbuild added this to the CMSSW_11_0_X milestone May 28, 2019

cmsbuild added code-checks-pending comparison-pending new-package-pending orp-pending pending-signatures tests-pending labels May 28, 2019

mrodozov added a commit to cms-sw/cms-bot that referenced this pull request May 28, 2019

Add package L1Trigger/RPCTriggerPrimitives

886bd84

Needed by: cms-sw/cmssw#26967

mrodozov mentioned this pull request May 28, 2019

Add package L1Trigger/RPCTriggerPrimitives cms-sw/cms-bot#1146

Closed

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 28, 2019

Trigger primitive phase2 @maseguracern code check

fe5f729

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 28, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels May 28, 2019

cmsbuild added the l1-pending label May 29, 2019

cmsbuild removed the tests-pending label May 30, 2019

cmsbuild added the code-checks-approved label Jul 4, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 4, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 4, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 4, 2019

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jul 9, 2019

cmsbuild added orp-approved and removed orp-pending labels Jul 9, 2019

cmsbuild merged commit fdb7b71 into cms-sw:master Jul 9, 2019

Dr15Jones reviewed Jul 10, 2019

View reviewed changes

fabiocos mentioned this pull request Jul 10, 2019

Revert "Primitive RPC trigger" #27481

Merged

slava77 mentioned this pull request Jul 10, 2019

RecoEgamma/EgammaElectronProducers cleanup #27477

Merged

fabiocos mentioned this pull request Jul 11, 2019

Problem with plugin for RPC Trigger Primitive #27491

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Primitive RPC trigger #26967

Primitive RPC trigger #26967

maseguracern commented May 28, 2019

cmsbuild commented May 28, 2019

cmsbuild commented May 28, 2019

cmsbuild commented May 28, 2019

cmsbuild commented May 28, 2019

cmsbuild commented May 28, 2019

smuzaffar commented May 29, 2019

cmsbuild commented May 29, 2019

maseguracern commented May 29, 2019

rekovic commented May 30, 2019

cmsbuild commented May 30, 2019 •

edited

cmsbuild commented Jul 4, 2019

fabiocos commented Jul 4, 2019

cmsbuild commented Jul 4, 2019 •

edited

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

fabiocos commented Jul 5, 2019

rekovic commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

fabiocos commented Jul 9, 2019

Dr15Jones Jul 10, 2019

Dr15Jones Jul 10, 2019

Dr15Jones Jul 10, 2019

maseguracern Jul 17, 2019

Dr15Jones Jul 17, 2019

maseguracern Jul 17, 2019

Dr15Jones Jul 17, 2019

maseguracern Jul 18, 2019

Dr15Jones Jul 18, 2019

maseguracern Jul 18, 2019

Dr15Jones Jul 18, 2019

maseguracern Jul 18, 2019

fabiocos commented Jul 10, 2019

Primitive RPC trigger #26967

Primitive RPC trigger #26967

Conversation

maseguracern commented May 28, 2019

cmsbuild commented May 28, 2019

cmsbuild commented May 28, 2019

cmsbuild commented May 28, 2019

cmsbuild commented May 28, 2019

cmsbuild commented May 28, 2019

smuzaffar commented May 29, 2019

cmsbuild commented May 29, 2019

maseguracern commented May 29, 2019

rekovic commented May 30, 2019

cmsbuild commented May 30, 2019 • edited

cmsbuild commented Jul 4, 2019

fabiocos commented Jul 4, 2019

cmsbuild commented Jul 4, 2019 • edited

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

fabiocos commented Jul 5, 2019

rekovic commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

fabiocos commented Jul 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabiocos commented Jul 10, 2019

cmsbuild commented May 30, 2019 •

edited

cmsbuild commented Jul 4, 2019 •

edited