Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlap fixes in Totem #2700

Merged
merged 6 commits into from Mar 3, 2014

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Mar 3, 2014

  • Fix Totem overlap with beampipe

@ianna
Copy link
Contributor Author

ianna commented Mar 3, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2014

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

Overlap fixes in Totem

It involves the following packages:

Configuration/Geometry
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData
Geometry/TrackerSimData
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Mar 3, 2014

+1
@ianna, probably you need to edit the title of this PR because it is not only fix for Totem but extended pixel.

What part of this PR should go into 7_1_X?

@ianna
Copy link
Contributor Author

ianna commented Mar 3, 2014

@civanch - Tracker changes are in a separate PR. When it is integrated, there will be only one commit left. I'm preparing a new branch for 71x.

@mark-grimes
Copy link

merge

Tested #2677, #2696, #2700 and #2701 together.
10000, 10200, 10400, 11200, 11400, 11600, 11800, and 12000 pass all steps.
12200, 12400, 12600, 12800, 13200 and 13400 fail in step 2 (132xx and 134xx are new with #2701).
13000 fails in step 3.
This is the case without these pull requests, so merging them in.

cmsbuild added a commit that referenced this pull request Mar 3, 2014
@cmsbuild cmsbuild merged commit c13fd33 into cms-sw:CMSSW_6_2_X_SLHC Mar 3, 2014
@ianna ianna deleted the overlap-fixes-in-totem branch October 26, 2015 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants