Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCal] Material budget from vertex up to in front of muon stations #27126

Merged
merged 4 commits into from Jun 11, 2019

Conversation

apsallid
Copy link
Contributor

@apsallid apsallid commented Jun 6, 2019

PR description:

The new V10 HGCal geometry in D41 scenario introduces significant reduction of material budget from V9 (~1.5λ). Motivated by the strong interest in how is this change effecting the Muon system, we estimated (@felicepantaleo , @rovere ) the total thickness, in nuclear interaction lengths, in front of Muon Stations versus eta, starting from the vertex.

In this PR, we add the relevant changes that are necessary to perform the above study. Special care was taken so that the existing HGCal material budget study is not effected, so that someone can easily run both tasks without any conflict.

PR validation:

The results of this work has been presented in the HGCal DPG [1] and we have checked that the standard HGCal material budget study presented previously [2] is not effected and the two can be run side by side.

Detailed instructions on running the standard HGCal material budget study has been written in the HGCal webpage [3] while more instructions on the current study will be added in the same place.

if this PR is a backport please specify the original PR:

This is not a backport.

[1] https://indico.cern.ch/event/820095/contributions/3428509/attachments/1844946/3026574/MatBudInFrontofMuonStations_15May19.pdf

[2] https://indico.cern.ch/event/813555/contributions/3400815/attachments/1831509/2999507/Psallidas-MaterialBudgetV10.pdf

[3] http://hgcal.web.cern.ch/hgcal/MaterialBudget/MaterialBudget/

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27126/10254

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2019

A new Pull Request was created by @apsallid for master.

It involves the following packages:

Validation/Geometry

@andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks.
@vargasa, @rishabhCMS, @rovere, @rbartek this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 6, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/801/console Started: 2019/06/06 17:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f1385/801/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3215458
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215123
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 7, 2019

+1

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants