Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code format fixes after CMSSW_11_0_X_2019-06-06-2300 #27143

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Jun 7, 2019

PR description:

Post clang-format fixes according to review comments for PRs integrated up to CMSSW_11_0_X_2019-06-06-2300.

PR validation:

Code compiles

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27143/10280

  • This PR adds an extra 152KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

CondFormats/SiPixelTransient
DataFormats/Luminosity
DataFormats/MuonReco
DataFormats/TauReco
EventFilter/CSCRawToDigi
EventFilter/GEMRawToDigi
EventFilter/SiStripRawToDigi
GeneratorInterface/RivetInterface
RecoCTPPS/PixelLocal
RecoEcal/EgammaCoreTools
RecoMET/METProducers
RecoMuon/MuonSeedGenerator
RecoParticleFlow/PFTracking
RecoTracker/ConversionSeedGenerators
RecoTracker/SpecialSeedGenerators
RecoTracker/TkNavigation
RecoTracker/TrackProducer
TrackingTools/TrackFitters

@perrotta, @efeyazgan, @cmsbuild, @alberto-sanchez, @agrohsje, @slava77, @ggovi, @qliphy can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @felicepantaleo, @jainshilpi, @abbiendi, @argiro, @jshlee, @alberto-sanchez, @ahinzmann, @lgray, @varuns23, @seemasharmafnal, @mmarionncern, @battibass, @makortel, @jhgoh, @dgulhan, @jdolen, @HuguesBrun, @agrohsje, @drkovalskyi, @ptcox, @trocino, @forthommel, @rociovilar, @Sam-Harper, @barvic, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @mschrode, @ebrondol, @amagitte, @clelange, @echapon, @mkirsano, @jan-kaspar, @calderona, @hatakeyamak, @folguera, @Martin-Grunewald, @cbernet, @gpetruc, @mariadalfonso, @mmusich, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Jun 7, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/827/console Started: 2019/06/07 12:00

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2da66/827/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3215458
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215123
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor Author

fabiocos commented Jun 8, 2019

@slava77 @perrotta this PR addresses a number of comments of yours (besides others from myself), I will move forward unless you have objections

@perrotta
Copy link
Contributor

perrotta commented Jun 9, 2019

+1

  • It improves manually on a few weird clang-formatting choices

@fabiocos
Copy link
Contributor Author

fabiocos commented Jun 9, 2019

+1

@ggovi @efeyazgan @qliphy please have a look in case

@fabiocos
Copy link
Contributor Author

fabiocos commented Jun 9, 2019

merge

@cmsbuild cmsbuild merged commit b2e446e into cms-sw:master Jun 9, 2019
@fabiocos fabiocos deleted the fc-fixFormat20190607 branch June 13, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants