Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCALDQM: Updates for Run 3 HB (10_6_X backport) #27152

Merged
merged 7 commits into from
Jun 19, 2019

Conversation

DryRun
Copy link
Contributor

@DryRun DryRun commented Jun 7, 2019

Backport of #27149

PR description:
This PR implements Run 3 HB in HCAL DQM. The old HBHEDigiCollection is removed, and the new HB digis are taken from QIE11DigiCollection. Since HB now overlaps with HO in (ieta, iphi, depth) space, HO digis are plotted in depth 7 for now. A future PR will improve on that hack, moving HO (and perhaps all subsystems) to their own ieta-iphi plots, rather than attempting to plot all subsystems together.

PR validation:
Successfully ran over recent local and global runs with partial HB installation. Note that running in online DQM will require appropriate conditions, which are being developed in parallel.
runTheMatrix was successful, particularly the one that failed in the last PR (136.731).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

A new Pull Request was created by @DryRun (David Yu) for CMSSW_10_6_X.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks
DQM/Integration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@deguio, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/843/console Started: 2019/06/08 10:05

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6588f4/843/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3206400
  • DQMHistoTests: Total failures: 467
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3205599
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 286.0 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 250202.181,... ): 13.000 KiB Hcal/DigiTask
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

@DryRun the PR is apparently creating the ADC plots from QIE11DigiCollection empty (see e.g. http://tinyurl.com/y3vehmf3 which compare base QIE8 http://tinyurl.com/y2adbjqo with the base+PR http://tinyurl.com/y42aohxg and other MEs in the links). Can you confirm this is expected?

Can you also check if the output produced is OK across workflows? In particular I don't see any ME related to depth 7 as you mentioned in the PR description:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_6_X_2019-06-07-2300+6588f4/32161/dqm-histo-comparison-summary.html
Thanks!

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

identical backport from 11_0_X

@cmsbuild cmsbuild merged commit e6888e9 into cms-sw:CMSSW_10_6_X Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants