-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCALDQM: Updates for Run 3 HB (10_6_X backport) #27152
HCALDQM: Updates for Run 3 HB (10_6_X backport) #27152
Conversation
A new Pull Request was created by @DryRun (David Yu) for CMSSW_10_6_X. It involves the following packages: DQM/HcalCommon @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@DryRun the PR is apparently creating the ADC plots from QIE11DigiCollection empty (see e.g. http://tinyurl.com/y3vehmf3 which compare base QIE8 http://tinyurl.com/y2adbjqo with the base+PR http://tinyurl.com/y42aohxg and other MEs in the links). Can you confirm this is expected? Can you also check if the output produced is OK across workflows? In particular I don't see any ME related to depth 7 as you mentioned in the PR description: |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 identical backport from 11_0_X |
Backport of #27149
PR description:
This PR implements Run 3 HB in HCAL DQM. The old HBHEDigiCollection is removed, and the new HB digis are taken from QIE11DigiCollection. Since HB now overlaps with HO in (ieta, iphi, depth) space, HO digis are plotted in depth 7 for now. A future PR will improve on that hack, moving HO (and perhaps all subsystems) to their own ieta-iphi plots, rather than attempting to plot all subsystems together.
PR validation:
Successfully ran over recent local and global runs with partial HB installation. Note that running in online DQM will require appropriate conditions, which are being developed in parallel.
runTheMatrix was successful, particularly the one that failed in the last PR (136.731).