[RFC] Remove FastSimGeometryESProducer as obsolete

[makortel]

PR description:

As part of #26748 I noticed that even if FastSimGeometryESProducer itself does not consume any ES products, its product fastsim::Geometry has a non-const update() method that update its state based on products read from edm::EventSetup

cmssw/FastSimulation/SimplifiedGeometryPropagator/src/Geometry.cc

Lines 49 to 52 in 07cbc89

	void Geometry::update(const edm::EventSetup& iSetup,
	const std::map<std::string, fastsim::InteractionModel*>& interactionModelMap) {
	if (iSetup.get<TrackerRecoGeometryRecord>().cacheIdentifier() == cacheIdentifierTrackerRecoGeometry_ &&
	iSetup.get<IdealMagneticFieldRecord>().cacheIdentifier() == cacheIdentifierIdealMagneticField_) {

This violates the rule that ES products may be accessed only through const methods.

The update() method is called from

cmssw/FastSimulation/SimplifiedGeometryPropagator/plugins/FastSimProducer.cc

Lines 166 to 167 in 07cbc89

	geometry_.update(iSetup, interactionModelMap_);
	caloGeometry_.update(iSetup, interactionModelMap_);

On the other hand, I didn't see any consumers for the fastsim::Geometry ES product, so I'm asking if the FastSimGeometryESProducer can just be removed, or if there is any planned use for it in the future?

PR validation:

FastSim workflow 5.1,135.4,2017.1,2018.1 run successfully.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27157/10302

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FastSimulation/Configuration
FastSimulation/SimplifiedGeometryPropagator

@cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/859/console Started: 2019/06/10 20:19

[cmsbuild]

+1
Tested at: d62d7da
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-447c17/859/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-447c17/859/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3215458
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215122
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[makortel]

@ssekmen @skurz Could you please take a look and comment?

[ssekmen]

Thanks @makortel . I think we can remove it for the time being.

[ssekmen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1