Fix assert failure in readLuminosityBlock

[wddgit]

PR description:

We are having a rare, nonreproducible failure in
EventProcessor::readLuminosityBlock in the IBs.
The symptom is an assert because the pointer to
the LuminosityBlockPrincipal is null. If the
LuminosityBlockProcessingStatus object was being
destroyed before calling resumeGlobalLumiQueue
then such a failure could occur because the order the
of the member variables in LuminosityBlockProcessingStatus
is wrong. We should free the LuminosityBlockPrincipal
before resuming the lumi queue. I am not sure this will
actually help though, because I can see no way to get
into this state. The existing code tries to always call
resumeGlobalLumiQueue, but this should eliminate at least
one possible source for the assert we have seen.

This should not change any behavior except maybe in some
complex case where we are already dealing with an unrelated
exception.

PR validation:

Run existing unit tests.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27158/10304

• This PR adds an extra 16KB to repository

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/860/console Started: 2019/06/10 20:52

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 2319d15
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a43d3/860/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a43d3/860/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3215458
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215122
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1