Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for simulation #27165

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Conversation

cmsbuild
Copy link
Contributor

Applying code-format for CMSSW category simulation.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/394//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27165/10315

  • This PR adds an extra 8KB to repository

@smuzaffar
Copy link
Contributor

ping

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 11, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/887/console Started: 2019/06/11 22:49

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/MuonDetId

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@battibass, @trocino, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @ptcox, @rovere, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a50e90/887/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3215458
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215123
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented Jun 12, 2019

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

Copy link
Contributor

@fabiocos fabiocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few lines may not be split by moving comments


return (result <= 6) ? result : 6; // max sector is 6, some calculations give a value greater than six but this is expected.
return (result <= 6) ? result
: 6; // max sector is 6, some calculations give a value greater than six but this is expected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fixed

if (station != 1)
if (TriggerCSCID <= 3)
chamber =
(TriggerCSCID + 3 * (TriggerSector - 1)) % 18 + 1; // Derived from CMS Note: CMS IN 2000/04 ver 2.1 Oct/2005
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fixed

return (result <= 6) ? result : 6; // Max sector is 6, some calculations give a value greater than six but this is expected
// and delt with.
return (result <= 6) ? result
: 6; // Max sector is 6, some calculations give a value greater than six but this is expected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fixed

DetId(chId.rawId() & chamberIdMask_) { // The mask is required for proper slicing, i.e. if chId is actually a derived class.
DTChamberId::DTChamberId(const DTChamberId& chId)
: DetId(chId.rawId() &
chamberIdMask_) { // The mask is required for proper slicing, i.e. if chId is actually a derived class.
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fixed

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants