-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running code-format for simulation #27165
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27165/10315
|
ping |
The tests are being triggered in jenkins. |
A new Pull Request was created by @cmsbuild for master. It involves the following packages: DataFormats/MuonDetId @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few lines may not be split by moving comments
|
||
return (result <= 6) ? result : 6; // max sector is 6, some calculations give a value greater than six but this is expected. | ||
return (result <= 6) ? result | ||
: 6; // max sector is 6, some calculations give a value greater than six but this is expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
if (station != 1) | ||
if (TriggerCSCID <= 3) | ||
chamber = | ||
(TriggerCSCID + 3 * (TriggerSector - 1)) % 18 + 1; // Derived from CMS Note: CMS IN 2000/04 ver 2.1 Oct/2005 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
return (result <= 6) ? result : 6; // Max sector is 6, some calculations give a value greater than six but this is expected | ||
// and delt with. | ||
return (result <= 6) ? result | ||
: 6; // Max sector is 6, some calculations give a value greater than six but this is expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
DetId(chId.rawId() & chamberIdMask_) { // The mask is required for proper slicing, i.e. if chId is actually a derived class. | ||
DTChamberId::DTChamberId(const DTChamberId& chId) | ||
: DetId(chId.rawId() & | ||
chamberIdMask_) { // The mask is required for proper slicing, i.e. if chId is actually a derived class. | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
+1 |
Applying code-format for CMSSW category simulation.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/394//console
cms-bot has successfully run the following: