Avoid segfault in playback mode if no files specified #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_0_X. Avoid segfault in playback mode if no files specified It involves the following packages: IOPool/Input @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
+1 |
ktf
added a commit
that referenced
this pull request
Mar 6, 2014
…ist70X Framework fix -- Avoid segfault in playback mode if no files specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the mixing module in playback mode, if the secondary input source is given an empty file list, a segfault resulted when attempting to throw an exception. This pull request fixes the segfault so that the exception is thrown.
This pull request also improves exception messages that occur on an empty file list for the secondary source when playback mode is not used.
This code bug has been there for a long time. This segfault has been observed as far back as 5_3_X.
Pull request requested in 7_0_X by David Lange.