HCAL: making ped.width ADC2fC ped.-aware #27235
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27235/10421
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27235/10422
|
|
A new Pull Request was created by @abdoulline (Salavat Abdullin) for master. It involves the following packages: CalibFormats/HcalObjects @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27235/10487
|
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@abdoulline from your discussion I understand that this PR is still valid for the legacy pre-Run3 data, apart for fluctuations. So far it is not Era dependent, so it will equally be applied everywhere. |
|
+1 |
|
Yes, Fabio, it's era-independent (in the sense that effect on previous
eras is only "rounding" = negligible and ped.widths in question are used
"indirectly" for MAHI fit error estimator)
…On Fri, 21 Jun 2019, Fabio Cossutti wrote:
@abdoulline from your discussion I understand that this PR is still valid for the legacy pre-Run3 data, apart for fluctuations. So far it is not Era
dependent, so it will equally be applied everywhere.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[ABGHJWXMRHS5PKTVQZ6JMHLP3SFYTA5CNFSM4HY6Z3CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYHZUNQ.gif]
|
PR description:
Old pedestal width conversion from ADC to fC assumed the values are small and lie within (linear) 1st sub-range of 1st range of QIE calibration. This assumption is no more valid for high HB/HE (SiPMs-dark-current-related) effective pedestals and ped.widths at the end of Run3.
An issue has been observed in Run3 2023/2024 MC tests and is fixed by this PR.
PR validation:
runTheMatris -s is OK
Private sanity check test with pion gun "CaloScan" for Run3 2021 shows no difference (modulo Digi rndm sequence change)
https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/11_X/11_0_X_run3_pedfix_vs_11_0_0_pre2_run3_SinglePi/
if this PR is a backport please specify the original PR:
This PR affects(fixes) solely end-of-Run3 MC.
Eras <=2018, regular Run3_2021 and Phase2 are OK without it.
May not need back-porting, if HCAL will submit updated end-of-Run3 ("2023,2024") pedestals & ped.widths in fC.