Remove SiStripDetInfoFileReader as an edm::Service #27292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cDet (to replace some SiStripDetInfoFileReader uses)
…oFileReader to SiStrip DetId list
…of SiStripDetInfoFileReader to SiStrip DetId list
… instead of SiStripDetInfoFileReader
…tead of as an edm::Service
…f DetIds from GeometricDet
…(and simplify, removing inheritance)
…ripDetInfoFileReader
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
As pointed out by @makortel the SiStripDetInfoFileReader service was violating framework policy by providing "physics data" (the list of strip tracker modules, and the number of APVs and strip length for each), so this is an attempt to remove it where it was used in that way.
The same information can be obtained also from the geometry (GeometricDet on the IdealGeometryRecord for the list of DetIds, TrackerGeometry on the TrackerDigiGeometryRecord for the full information), so for the cases where that was available anyway (or could easily be added) I moved to that.
There are a few cases (the SiStripCondObjBuilderFromDb service, and ES producers of with "fake" content - e.g. set with parameters, random - of conditions that do not depend on any of these records). Those I changed to use their own SiStripDetInfoFile instance.
PR validation:
Compiled and ran unittests. Also checked that the configs for standalone use of the GeometricDet/TrackerGeometry work and give the same information, see here.
I did however not run all configs that I edited (many are for standalone tests, production of conditions etc., and several looked quite outdated), so it would be great if the relevant people (Strip online/DAQ, tracker DQM etc.) could have a look at those.