New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing link to rootmlp in PhysicsTools/PatUtils #27317
Conversation
The link is needed to make UBSAN work as it needs to access the virtual table for any class used which has a virtual function.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27317/10546
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: PhysicsTools/PatUtils @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
The link is needed to make UBSAN work as it needs to access the virtual table for any class used which has a virtual function.
PR validation:
The code compiles and links using the CMSSW_11_0_UBSAN_X_2019-06-21-2300 IB.