Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change profiler format for igprof #27338

Merged
merged 3 commits into from Jun 27, 2019
Merged

Change profiler format for igprof #27338

merged 3 commits into from Jun 27, 2019

Conversation

gudrutis
Copy link
Contributor

@gudrutis gudrutis commented Jun 25, 2019

PR description:

This PR should fix like this issue cms-sw/cms-bot#1151
The issue is that the current format sometimes produces really long filenames which igProf cannot open, thus we are missing some steps.

PR validation:

Tested locally by running runTheMatrix.py -i all -l 136.731 --command '-n 1 --profile pp' --ibeos on latest CMSSW enviroment.

if this PR is a backport please specify the original PR:

Not a backport.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27338/10590

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gudrutis (Zygimantas Matonis) for master.

It involves the following packages:

Configuration/Applications

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

clearly not testing igprof in itself...

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1153/console Started: 2019/06/25 16:16

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54b843/1153/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254598
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3254261
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

The fix seems to do the job, running

runTheMatrix.py -l 136.731 --command "-n 10 --profile pp" --ibeos

gives as a result:

total 161260
-rw-r--r--. 1 fabiocos zh       26 Jun 27 13:06 step1_lumiRanges.log
-rw-r--r--. 1 fabiocos zh     2020 Jun 27 13:06 step1_dasquery.log
-rw-r--r--. 1 fabiocos zh     7046 Jun 27 13:06 step2_L1REPACK_HLT.py
-rw-r--r--. 1 fabiocos zh   175414 Jun 27 13:07 step2___0adcf443fa77e08c73b673d108c0590d___1.gz
-rw-r--r--. 1 fabiocos zh 13620931 Jun 27 13:07 step2.root
-rw-r--r--. 1 fabiocos zh   187812 Jun 27 13:07 step2___0adcf443fa77e08c73b673d108c0590d___10_EndOfJob.gz
-rw-r--r--. 1 fabiocos zh     3779 Jun 27 13:07 step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log
-rw-r--r--. 1 fabiocos zh   199832 Jun 27 13:07 igprof.cmsRun.12651.1561633649.659021.gz
-rw-r--r--. 1 fabiocos zh    70023 Jun 27 13:08 step3_RAW2DIGI_L1Reco_RECO_SKIM_EI_PAT_ALCA_DQM.py
-rw-r--r--. 1 fabiocos zh   840451 Jun 27 13:11 step3___471f183eeda284e57fabd523c6469c29___1.gz
-rw-r--r--. 1 fabiocos zh  3558574 Jun 27 13:12 EcalESAlign.root
-rw-r--r--. 1 fabiocos zh  7560055 Jun 27 13:12 SiStripCalMinBias.root
-rw-r--r--. 1 fabiocos zh  5787217 Jun 27 13:12 SiStripCalZeroBias.root
-rw-r--r--. 1 fabiocos zh  3677644 Jun 27 13:12 TkAlMinBias.root
-rw-r--r--. 1 fabiocos zh 17064289 Jun 27 13:12 step3_inDQM.root
-rw-r--r--. 1 fabiocos zh  3190842 Jun 27 13:12 step3_inMINIAOD.root
-rw-r--r--. 1 fabiocos zh 17707734 Jun 27 13:12 step3.root
-rw-r--r--. 1 fabiocos zh  5788041 Jun 27 13:12 EXOMONOPOLE.root
-rw-r--r--. 1 fabiocos zh  3393187 Jun 27 13:12 SinglePhotonJetPlusHOFilter.root
-rw-r--r--. 1 fabiocos zh  1111217 Jun 27 13:12 step3___471f183eeda284e57fabd523c6469c29___10_EndOfJob.gz
-rw-r--r--. 1 fabiocos zh   185831 Jun 27 13:12 step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log
-rw-r--r--. 1 fabiocos zh  1131850 Jun 27 13:12 igprof.cmsRun.12728.1561633965.481062.gz
-rw-r--r--. 1 fabiocos zh     2598 Jun 27 13:12 cmdLog
-rw-r--r--. 1 fabiocos zh     5085 Jun 27 13:12 step4_HARVESTING.py
-rw-r--r--. 1 fabiocos zh 79035832 Jun 27 13:14 DQM_V0001_R000274199__Global__CMSSW_X_Y_Z__RECO.root
-rw-r--r--. 1 fabiocos zh   240330 Jun 27 13:14 step4___84606aaf7f7845eb1cdce5fbf68c6742___0_EndOfJob.gz
-rw-r--r--. 1 fabiocos zh   260580 Jun 27 13:14 step4_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log
-rw-r--r--. 1 fabiocos zh   245377 Jun 27 13:14 igprof.cmsRun.13168.1561634060.394785.gz

@fabiocos
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants