Switched from Xerces to tinyxml2 for Services #27339
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27339/10594
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27339/10595
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Catalog @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 09a7389 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Building shared library tmp/slc7_amd64_gcc700/src/L1TriggerConfig/L1GtConfigProducers/src/L1TriggerConfigL1GtConfigProducers/libL1TriggerConfigL1GtConfigProducers.so tmp/slc7_amd64_gcc700/src/L1TriggerConfig/L1GtConfigProducers/src/L1TriggerConfigL1GtConfigProducers/L1GtTriggerMenuXmlParser.cc.o: In function `L1GtTriggerMenuXmlParser::initXML(std::__cxx11::basic_string, std::allocator > const&)': L1GtTriggerMenuXmlParser.cc:(.text+0x2515): undefined reference to `cms::concurrency::xercesInitialize()' tmp/slc7_amd64_gcc700/src/L1TriggerConfig/L1GtConfigProducers/src/L1TriggerConfigL1GtConfigProducers/L1GtTriggerMenuXmlParser.cc.o: In function `L1GtTriggerMenuXmlParser::cleanupXML(xercesc_3_1::XercesDOMParser*)': L1GtTriggerMenuXmlParser.cc:(.text+0x1db): undefined reference to `cms::concurrency::xercesTerminate()' collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc700/src/L1TriggerConfig/L1GtConfigProducers/src/L1TriggerConfigL1GtConfigProducers/libL1TriggerConfigL1GtConfigProducers.so] Error 1 Leaving library rule at L1TriggerConfig/L1GtConfigProducers >> Leaving Package L1TriggerConfig/L1GtConfigProducers >> Package L1TriggerConfig/L1GtConfigProducers built >> Leaving Package CondCore/Utilities arg1= |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
We already are dependent on tinyxml2 from MessageLogger. In addition, tinyxml2 is more thread friendly and seems lighter weight.
The default value for the URL needs to use the CMS_PATH environment variable.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27339/10618
|
|
Pull request #27339 was updated. @cmsbuild, @smuzaffar, @benkrikler, @Dr15Jones, @rekovic can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@rekovic the L1 part of this PR is minimal and purely technical, please have a look, I will integrate it in next IB |
|
+1 |
|
merge |
PR description:
We already are dependent on tinyxml2 from MessageLogger. In addition, tinyxml2 is more thread friendly and seems lighter weight.
PR validation:
Code compiles and framework related tests pass.