New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct name for key and value #2738
Use correct name for key and value #2738
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X. Use correct name for key and value It involves the following packages: CondCore/ORA @ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks. |
Pull request #2738 was updated. @apfeiffer1, @Dr15Jones, @cmsbuild, @nclopezo, @ggovi, @Degano, @ktf can you please check and sign again. |
ROOT6 -- Use correct name for key and value
Merged. @davidlt looks like the ROOT6 IB validation gets stuck since a few days. Can you please look into it? Thanks. |
@ktf looks like they are timing out (12hr limit). Let's see which workflows keeps RelVals hanged in a several hours as Jenkins just started ROOT6 validation job. |
No, they are not timing out because the "validation–" step for ROOT6 does not have the timeout enabled @nclopezo should be looking into it. If you can understand the problem it would be great. |
From all recent validation jobs:
|
http://vocms117.cern.ch:8080/jenkins/job/validation-CMSSW_7_1_ROOT6_X-slc5_amd64_gcc481/68/ Started 4 days 2 hr ago what are you looking at? On 6 Mar 2014, at 9:51, davidlt wrote:
|
Hi, In the configuration for slc6 the timeout is set: https://cmssdt.cern.ch/jenkins/job/validation-CMSSW_7_1_ROOT6_X-slc6_amd64_gcc481/configure https://cmssdt.cern.ch/jenkins/job/validation-CMSSW_7_1_ROOT6_X-slc6_amd64_gcc481/32/console I will look at the logs for slc5 in lxbuild049 On Thu, Mar 6, 2014 at 10:15 AM, Giulio Eulisse notifications@github.comwrote:
David Mendez |
David and Giulio, |
@wmtan I looked into running RelVals and I agree. Currently I don't see any workflows being stuck and I see them running, usually sampling workflows I see that they are usually in Cling (e.g., compiling). Some errors still exist:
Some grep magic on currently running RelVals:
90 such fatal exceptions so far. You can find such exceptions in:
|
David, |
This pull request is a fix for a fatal problem for about half of the relval tests in the ROOT6 IB.
The conditions code uses a complicated code to determine the names "key_type" and "value_type",
(typedefs of data members of STL collections), which never change. Unfortunately, the new framework code returns the name of the underlying type rather than the name of the typedef. Since the names returned never change, the easiest way to fix this is simply to hard code the the strings "key_type" and "value_type".
Also in this pull request is a fix for multidimensioned C arrays. All but the first index were dropped due to s simple bug in MemberWithDict, which is fixed in this request.
Please merge this promptly unless there are issues.