Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for relval_8.2 job splitting issue #27436

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

ahmad3213
Copy link
Contributor

New relval 8.2 (Beamhalo 2021) was introduced in PR#26510 (#26510). It had issue with job splitting, relvals was failing because of too much Wall Clock time. In this PR just two lines added to fix this issue. The discussion for the issue can be seen at following ticket
https://its.cern.ch/jira/browse/CMSCOMPPR-6894

Thanking you .
Best,
Muhammad Ahmad

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27436/10743

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2019

A new Pull Request was created by @ahmad3213 (Muhammad Ahmad ) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Jul 4, 2019

please test workflow 8.2

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1326/console Started: 2019/07/04 16:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06f331/1326/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-06f331/8.2_BeamHalo_UP21+BeamHalo_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCABH_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3160399
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3160064
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented Jul 5, 2019

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 9, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 9, 2019

+1

@cmsbuild cmsbuild merged commit f9b9765 into cms-sw:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants