g4SimHits changes in the source code needed to include PPS

[mundim]

PR description:

Changes need in OscarProducer.cc and OscarMTProducer.cc (SimG4Core/Application) in order to include PPS sim hits (the config has not been changed yet, only source code).

PR validation:

scram b runtests
and
runTheMatrix.py --job-reports -j 14 -s -l limited -i all --ibeos
with output:

31 25 16 13 9 1 0 0 0 tests passed, 2 5 9 0 0 0 0 0 0 failed

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27438/10744

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mundim for master.

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1321/console Started: 2019/07/04 12:54

[cmsbuild]

+1
Tested at: 95ad466
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44e7a/1321/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44e7a/1321/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3160399
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3160064
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@mundim @civanch this PR is in itself self consistent and harmless, but what is the plan behind to fill the added collections? What is the urgency to add an empty collection?

[mundim]

@mundim @civanch this PR is in itself self consistent and harmless, but what is the plan behind to fill the added collections? What is the urgency to add an empty collection?

This is indeed quite urgent. This is part of a much bigger PR that is ongoing since last year. After complaints about its size (142 files, counting new and changed ones) we made an effort to split it is smaller, orthogonal PR towards the inclusion of PPS simulation in the release. Others are in preparation to be issued soon, including the code that will use/fill these collections.

[civanch]

@fabiocos , I asked to do so, to avoid interference with other development, in particular, DD4Hep migration. Doing this we make further PRs fully independent.

[fabiocos]

+1