Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-fwk02 Make use of name or fullname as option #27459

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 8, 2019

PR description:

Now the usage of name vs full name is given through an option. Default is to use full name. To use name rather than full name one need to set fullName=False in the cfg

PR validation:

Tested dumping some geometries

if this PR is a backport please specify the original PR:

No bak porting is required

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27459/10777

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27459/10778

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 8, 2019

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1361/console Started: 2019/07/08 17:07

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2019

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor

alja commented Jul 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 9, 2019

+1

@cmsbuild cmsbuild merged commit 2571aa8 into cms-sw:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants