Modernized ESProducers in TrackingTools/KalmanUpdators #27484

Dr15Jones · 2019-07-10T22:07:35Z

PR description:

Removed headers and put declaration in .cc files
Removed use of module.cc file
Pulled out parameters in constructor
Wrote fillDescriptions
Used edm::ESGetToken
Made KFSwitching1DUpdator not depend on ParameterSet

PR validation:

The code compiles. This is a refactoring and should not change any results.

Just pass the bool instead to the constructor.

cmsbuild · 2019-07-10T22:08:06Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-10T22:16:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27484/10815

This PR adds an extra 16KB to repository

cmsbuild · 2019-07-10T22:16:44Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

TrackingTools/KalmanUpdators

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @calderona, @HuguesBrun, @ebrondol, @rovere, @gpetruc, @bellan, @trocino, @dgulhan, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2019-07-11T08:25:24Z

please test

cmsbuild · 2019-07-11T08:25:47Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1413/console Started: 2019/07/11 10:26

cmsbuild · 2019-07-11T10:06:40Z

+1
Tested at: 10959a7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771918/1413/summary.html

cmsbuild · 2019-07-11T10:06:44Z

Comparison job queued.

cmsbuild · 2019-07-11T12:48:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771918/1413/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-771918/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-771918/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-771918/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3081858
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3081535
DQMHistoTests: Total skipped: 322
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

TrackingTools/KalmanUpdators/plugins/TrackingRecHitPropagatorESProducer.cc

-Removed headers and put declaration in .cc files -Removed use of module.cc file -Pulled out parameters in constructor -Wrote fillDescriptions -Used edm::ESGetToken

cmsbuild · 2019-07-11T16:15:35Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-11T16:22:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27484/10840

This PR adds an extra 16KB to repository

Dr15Jones · 2019-07-11T16:22:15Z

please test

cmsbuild · 2019-07-11T16:22:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1431/console Started: 2019/07/11 18:23

cmsbuild · 2019-07-11T16:22:27Z

Pull request #27484 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

cmsbuild · 2019-07-11T17:46:16Z

+1
Tested at: 67cbe90
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771918/1431/summary.html

cmsbuild · 2019-07-11T17:46:19Z

Comparison job queued.

cmsbuild · 2019-07-11T19:34:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771918/1431/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-771918/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-771918/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-771918/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3081858
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3081535
DQMHistoTests: Total skipped: 322
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

perrotta · 2019-07-12T05:33:43Z

+1

Technical changes, in line with the PR description
Jenkins tests pass and show no difference beside the slimmedJetsAK8 one, which also appears in other unrelated pull requests and it is therefore quite likely a random fluctuation (see deepAK8 reproducibility problems after switching to openblas #27504)

cmsbuild · 2019-07-12T05:34:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-07-12T20:47:36Z

+1

makortel · 2019-08-12T21:19:48Z

part of #26748

Removed ParameterSet dependency on KFSwitching1DUpdator

736df6c

Just pass the bool instead to the constructor.

cmsbuild added this to the CMSSW_11_0_X milestone Jul 10, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 10, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 10, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 11, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 11, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 11, 2019

perrotta reviewed Jul 11, 2019

View reviewed changes

TrackingTools/KalmanUpdators/plugins/TrackingRecHitPropagatorESProducer.cc Outdated Show resolved Hide resolved

TrackingTools/KalmanUpdators/plugins/TrackingRecHitPropagatorESProducer.cc Outdated Show resolved Hide resolved

Modernized ESProducers in TrackingTools/KalmanUpdators

67cbe90

-Removed headers and put declaration in .cc files -Removed use of module.cc file -Pulled out parameters in constructor -Wrote fillDescriptions -Used edm::ESGetToken

Dr15Jones force-pushed the modernizeKalmanUpdators branch from 10959a7 to 67cbe90 Compare July 11, 2019 16:15

cmsbuild removed code-checks-approved comparison-available labels Jul 11, 2019

cmsbuild added code-checks-pending comparison-pending tests-pending labels Jul 11, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 11, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 11, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 11, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 11, 2019

cmsbuild removed the pending-signatures label Jul 12, 2019

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending labels Jul 12, 2019

cmsbuild added orp-approved and removed orp-pending labels Jul 12, 2019

cmsbuild merged commit f59049b into cms-sw:master Jul 12, 2019

Dr15Jones deleted the modernizeKalmanUpdators branch July 30, 2019 20:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernized ESProducers in TrackingTools/KalmanUpdators #27484

Modernized ESProducers in TrackingTools/KalmanUpdators #27484

Dr15Jones commented Jul 10, 2019

cmsbuild commented Jul 10, 2019

cmsbuild commented Jul 10, 2019

cmsbuild commented Jul 10, 2019

perrotta commented Jul 11, 2019

cmsbuild commented Jul 11, 2019 •

edited

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

Dr15Jones commented Jul 11, 2019

cmsbuild commented Jul 11, 2019 •

edited

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

perrotta commented Jul 12, 2019 •

edited

cmsbuild commented Jul 12, 2019

fabiocos commented Jul 12, 2019

makortel commented Aug 12, 2019

Modernized ESProducers in TrackingTools/KalmanUpdators #27484

Modernized ESProducers in TrackingTools/KalmanUpdators #27484

Conversation

Dr15Jones commented Jul 10, 2019

PR description:

PR validation:

cmsbuild commented Jul 10, 2019

cmsbuild commented Jul 10, 2019

cmsbuild commented Jul 10, 2019

perrotta commented Jul 11, 2019

cmsbuild commented Jul 11, 2019 • edited

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

Dr15Jones commented Jul 11, 2019

cmsbuild commented Jul 11, 2019 • edited

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

perrotta commented Jul 12, 2019 • edited

cmsbuild commented Jul 12, 2019

fabiocos commented Jul 12, 2019

makortel commented Aug 12, 2019

cmsbuild commented Jul 11, 2019 •

edited

cmsbuild commented Jul 11, 2019 •

edited

perrotta commented Jul 12, 2019 •

edited