Run3-TB37 Update HGCal TB simulation

[bsunanda]

PR description:

Allow the test beam simulation to run with a few bug fixes

PR validation:

Since TB simulation is not in any standard workflows the changes were tested with private cfg files

if this PR is a backport please specify the original PR:

No back porting is needed

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27509/10861

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData
SimG4CMS/Calo
SimG4CMS/HGCalTestBeam

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1453/console Started: 2019/07/12 18:32

[cmsbuild]

+1
Tested at: 799512f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2daff/1453/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2daff/1453/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3081858
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3081535
• DQMHistoTests: Total skipped: 322
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

+upgrade

[bsunanda]

@ianna @cvuosalo @civanch Please approve

[cvuosalo]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@bsunanda I see that in this PR, besides the HGCal TB code there is also the ECAL APD configuration, recently removed from Geometry/EcalCommonData , reintroduced as a SinG4CMS/Calo test setup.
I understand this is not directly related to HGCal studies, but it could be in case useful to check back the APD simulation, am I correct?

[fabiocos]

+1