Modernized TkTransientTrackingRecHitBuilderESProducer #27510

Dr15Jones · 2019-07-12T16:26:35Z

PR description:

Removed headers and put declaration in .cc files
Removed use of module.cc file
Pulled out parameters in constructor
Wrote fillDescriptions
Used edm::ESGetToken

PR validation:

The code compiles. This is a refactoring and should not change any results.

cmsbuild · 2019-07-12T16:27:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-12T16:34:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27510/10862

This PR adds an extra 12KB to repository

cmsbuild · 2019-07-12T16:34:54Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoTracker/TransientTrackingRecHit

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2019-07-12T17:27:36Z

please test

cmsbuild · 2019-07-12T17:28:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1454/console Started: 2019/07/12 19:29

cmsbuild · 2019-07-12T20:05:24Z

-1

Tested at: e050ae7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0e008/1454/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

7.3 step3

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

136.85 step3

runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

158.0 step2

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

11624.0 step2

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35.log

250202.181 step3

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44.log

AddOn:

I found errors in the following addon tests:

cmsbuild · 2019-07-12T20:05:26Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

- Removed headers and put declaration in .cc files - Removed use of module.cc file - Pulled out parameters in constructor - Wrote fillDescriptions - Used edm::ESGetToken

cmsbuild · 2019-07-12T20:47:27Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-12T20:55:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27510/10868

This PR adds an extra 12KB to repository

cmsbuild · 2019-07-12T20:55:23Z

Pull request #27510 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

Dr15Jones · 2019-07-12T20:56:09Z

please test

cmsbuild · 2019-07-12T20:56:37Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1457/console Started: 2019/07/12 22:57

cmsbuild · 2019-07-12T22:20:02Z

+1
Tested at: 8c918de
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0e008/1457/summary.html

cmsbuild · 2019-07-12T22:20:05Z

Comparison job queued.

cmsbuild · 2019-07-13T00:28:43Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0e008/1457/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3081858
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3081534
DQMHistoTests: Total skipped: 322
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

perrotta · 2019-07-16T20:03:19Z

+1

Technical
Code changes in line with the PR description
Jenkins tests pass and show no difference

cmsbuild · 2019-07-16T20:04:30Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-07-17T20:35:19Z

+1

makortel · 2019-08-12T21:20:29Z

part of #26748

cmsbuild added this to the CMSSW_11_0_X milestone Jul 12, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 12, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 12, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 12, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 12, 2019

Modernized TkTransientTrackingRecHitBuilderESProducer

8c918de

- Removed headers and put declaration in .cc files - Removed use of module.cc file - Pulled out parameters in constructor - Wrote fillDescriptions - Used edm::ESGetToken

Dr15Jones force-pushed the modernizeTkTransientTrackingRecHitBuilderESProducer branch from e050ae7 to 8c918de Compare July 12, 2019 20:46

cmsbuild added code-checks-pending comparison-pending tests-pending and removed code-checks-approved comparison-notrun tests-rejected labels Jul 12, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 12, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 12, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 12, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 13, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jul 16, 2019

cmsbuild added orp-approved and removed orp-pending labels Jul 17, 2019

cmsbuild merged commit dab5022 into cms-sw:master Jul 17, 2019

Dr15Jones deleted the modernizeTkTransientTrackingRecHitBuilderESProducer branch July 30, 2019 20:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernized TkTransientTrackingRecHitBuilderESProducer #27510

Modernized TkTransientTrackingRecHitBuilderESProducer #27510

Dr15Jones commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

Dr15Jones commented Jul 12, 2019

cmsbuild commented Jul 12, 2019 •

edited

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

Dr15Jones commented Jul 12, 2019

cmsbuild commented Jul 12, 2019 •

edited

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 13, 2019

perrotta commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 17, 2019

makortel commented Aug 12, 2019

Modernized TkTransientTrackingRecHitBuilderESProducer #27510

Modernized TkTransientTrackingRecHitBuilderESProducer #27510

Conversation

Dr15Jones commented Jul 12, 2019

PR description:

PR validation:

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

Dr15Jones commented Jul 12, 2019

cmsbuild commented Jul 12, 2019 • edited

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

Dr15Jones commented Jul 12, 2019

cmsbuild commented Jul 12, 2019 • edited

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 12, 2019

cmsbuild commented Jul 13, 2019

perrotta commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 17, 2019

makortel commented Aug 12, 2019

cmsbuild commented Jul 12, 2019 •

edited

cmsbuild commented Jul 12, 2019 •

edited