Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix segfault in DQMCertCommonFakeHLT #27540

Merged
merged 1 commit into from Jul 17, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 17, 2019

PR description:

In PR #27467 a new sequence DQMCertCommonFakeHLT was introduced without taking into account one needs to exclude (for the time being) the sipixelCertification part.
This lead to failures in the IB CMSSW_11_0_X_2019-07-16-2300 (see logs ):

----- Begin Fatal Exception 17-Jul-2019 03:58:39 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global end LuminosityBlock run: 297557 luminosityBlock: 36
   [1] Calling method for module SiPixelCertification/'sipixelCertification'
Exception Message:
A std::exception was thrown.
DQM object not found: Pixel/EventInfo/reportSummary
----- End Fatal Exception -------------------------------------------------

I just move the definition of the sequence (which is basically a copy of the existing DQMCertCommon) after the copyAndExclude instruction is executed.
This makes the new sequence to inherit the exclusion of the offending sequence.
N.B. this is a temporary solution, as the ultimate fix would be to improve SiPixelCertification not to segfault for phase-1 pixel setup and remove all the copyAndExclude instructions.
@arossi83 is working on this, and an appropriate fix should come at later time.

PR validation:

I've re-run successfully the HARVESTING step of wf 136.789 with the changes proposed here.

runTheMatrix.py -l 136.789 -j 8 -t 4 

if this PR is a backport please specify the original PR:

This is not a backport

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27540/10920

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DQMOffline/Configuration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test workflow 136.789,136.892

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1500/console Started: 2019/07/17 10:52

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-225dfb/1500/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-225dfb/136.789_RunZeroBias2017B+RunZeroBias2017B+HLTDR2_2017+RECODR2_2017reHLT_ZBPrompt+HARVEST2017ZB
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-225dfb/136.892_RunZeroBias2018D+RunZeroBias2018D+HLTDR2_2018+RECODR2_2018reHLT_ZBPrompt+HARVEST2018_PromptZB

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2622600
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2622298
  • DQMHistoTests: Total skipped: 302
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@mmusich thanks for the fix, it will enter into next IB

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 50022b6 into cms-sw:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants