New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix segfault in DQMCertCommonFakeHLT #27540
fix segfault in DQMCertCommonFakeHLT #27540
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27540/10920
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: DQMOffline/Configuration @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 136.789,136.892 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@mmusich thanks for the fix, it will enter into next IB |
+1 |
PR description:
In PR #27467 a new sequence
DQMCertCommonFakeHLT
was introduced without taking into account one needs to exclude (for the time being) thesipixelCertification
part.This lead to failures in the IB CMSSW_11_0_X_2019-07-16-2300 (see logs ):
I just move the definition of the sequence (which is basically a copy of the existing
DQMCertCommon
) after thecopyAndExclude
instruction is executed.This makes the new sequence to inherit the exclusion of the offending sequence.
N.B. this is a temporary solution, as the ultimate fix would be to improve
SiPixelCertification
not to segfault for phase-1 pixel setup and remove all thecopyAndExclude
instructions.@arossi83 is working on this, and an appropriate fix should come at later time.
PR validation:
I've re-run successfully the HARVESTING step of wf 136.789 with the changes proposed here.
if this PR is a backport please specify the original PR:
This is not a backport