Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CTPSS from DQMOffline since it was breaking configuration in … #27571

Closed
wants to merge 1 commit into from

Conversation

jfernan2
Copy link
Contributor

R description:

This PR fixes issue with CTPPSDiamondDQMSource which was breaking the Run2017C for the recent relvals using DQM:@standardDQM+@ExtraHLT+@miniAODDQM

https://dmytro.web.cern.ch/dmytro/cmsprodmon/workflows.php?campaign=CMSSW_10_6_1__dataUL2017C_stdDQM-1562786386

DQMOffline/Configuration/python/DQMOffline_cff.py was being modified by CTPSS in a wrong way, modifying 2016 Eras but apparently affecting any Run2 year data

CTPSS should propose to DQM another strategy for the inclusion of validation in Run2 wf
PR validation:

Checked that RelVals are now produced as expected

@jfernan2
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27571/10969

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1556/console Started: 2019/07/19 23:16

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQMOffline/Configuration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2bba5/1556/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2557696
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2557393
  • DQMHistoTests: Total skipped: 302
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -220546.76 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 250202.181,... ): -6819.237 KiB CTPPS/TrackingPixel
  • DQMHistoSizes: changed ( 250202.181,... ): -3641.451 KiB CTPPS/TimingDiamond
  • DQMHistoSizes: changed ( 250202.181,... ): -3151.653 KiB CTPPS/TimingFastSilicon
  • DQMHistoSizes: changed ( 250202.181,... ): -1636.734 KiB CTPPS/TrackingStrip
  • DQMHistoSizes: changed ( 250202.181,... ): -502.930 KiB CTPPS/common
  • DQMHistoSizes: changed ( 250202.181,... ): -1.334 KiB CTPPS/DAQ
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@jfernan2
Copy link
Contributor Author

Closing it: supersed by #27571

@jfernan2 jfernan2 closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants