New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PPS][106X] Diamond DQM patch for 2017 #27591
[PPS][106X] Diamond DQM patch for 2017 #27591
Conversation
A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_10_6_X. It involves the following packages: DQM/CTPPS @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport of #27591 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Dare I ask what is the current status of this bug fix integration? |
+1 |
PR description:
This PR allows rechits with negative OOT index to be discarded in the population of the per-BX activity and pixel tomography monitoring plots for the PPS diamond detector. This allows to fix a
std::out_of_range
exception raised in e.g. 2017C relvals workflows (see e.g. here), as the time acquisition window was significantly larger (thus increasing the multiplicity of OOT hits).PR validation:
Same as #27586, successfully tested on the "faulty" workflow on a 10_6_1 release:
if this PR is a backport please specify the original PR: #27586
Before submitting your pull requests, make sure you followed this checklist: