Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove genreflex workaround. #27624

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

vgvassilev
Copy link
Contributor

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27624/11111

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vgvassilev (Vassil Vassilev) for master.

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1831/console Started: 2019/08/05 13:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 5, 2019

@alja could you please check?

1 similar comment
@fabiocos
Copy link
Contributor

@alja could you please check?

@fabiocos
Copy link
Contributor

@alja this seems to be forgotten, could you please have a look?

1 similar comment
@fabiocos
Copy link
Contributor

@alja this seems to be forgotten, could you please have a look?

@vgvassilev
Copy link
Contributor Author

Could we go ahead and merge it and rely on a post commit review if necessary?

@davidlange6
Copy link
Contributor

hi @fabiocos - seems we won't get the the attention of the remaining signer. it would seem the pr tests would have revealed the old problem had this old workaround still been needed.

@alja
Copy link
Contributor

alja commented Sep 18, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2ff97f1 into cms-sw:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants