-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove genreflex workaround. #27624
Remove genreflex workaround. #27624
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27624/11111
|
A new Pull Request was created by @vgvassilev (Vassil Vassilev) for master. It involves the following packages: Fireworks/Core @cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
@alja could you please check? |
1 similar comment
@alja could you please check? |
@alja this seems to be forgotten, could you please have a look? |
1 similar comment
@alja this seems to be forgotten, could you please have a look? |
Could we go ahead and merge it and rely on a post commit review if necessary? |
hi @fabiocos - seems we won't get the the attention of the remaining signer. it would seem the pr tests would have revealed the old problem had this old workaround still been needed. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
cc @davidlange6