Miscellanous fixes to SiPixel Bad Components db loaders

[mmusich]

PR description:

While producing MC bad component payloads for the Ultra-Legacy campaign we realized that several of the DB loaders for the various sources of Pixel bad components committed in release are not up-to-date with the latest recommendations.
In this PR SiPixelFEDChannelContainerWriteFromASCII.cc, SiPixelQualityProbabilitiesWriteFromASCII.cc (used to produce stuck-TBM simulation payloads) and SiPixelBadModuleByHandBuilder.cc ( used to produce permanently bad SiPixelQuality payloads) are updated together with the corresponding configuration files.

PR validation:

Changes concern only EDAnalyzers in test directories, which have all been privately tested.
No change is expected in any production workflow.

if this PR is a backport please specify the original PR:

This PR is not a backport
cc:
@tsusa @tvami

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27630/11120

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27630/11120/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27630/11120/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[mmusich]

@cmsbuild ping?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27630/11123

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondFormats/SiPixelObjects
CondTools/SiPixel

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng, @seemasharmafnal, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1693/console Started: 2019/07/29 21:03

[cmsbuild]

-1

Tested at: f417379

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d2c0a/1693/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27630/11398

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #27630 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please check and sign again.

[fabiocos]

@mmusich mine was mostly a request of clarification, anyway how you prefer

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1972/console Started: 2019/08/12 16:38

[cmsbuild]

+1
Tested at: 3f00d90
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d2c0a/1972/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d2c0a/1972/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[pohsun]

+1

[fabiocos]

@ggovi could you please check?

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1