New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD: Replace PseudoTrap shape by TruncTubs #27632
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27632/11125
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: Fireworks/Geometry @civanch, @Dr15Jones, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @alja, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: f1c805f You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test test2026Geometry had ERRORS |
Comparison job queued. |
What about |
For DD4hep, is it true we will not support the v1 muon yokes? |
@ianna a reminder that it is forbidden to edit the 2026 geometry configs directly. Instead please modify dict2026Geometry.py and rerun generate2026Geometry.py to maintain consistency between the concrete scenarios and the source dictionaries used to generate new scenarios. |
Comparison is ready Comparison Summary:
|
Comparison job queued. |
+1 |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1
|
+upgrade |
@alja - I've updated the Magnetic field geometry dump configuration to use correct XML files. Please, review. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The PseudoTrap shape was used only in Muon Yoke definition.
@cvuosalo - as we have discussed
PR validation:
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: