Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ESInputTag to ParameterDescription #27684

Merged
merged 1 commit into from
Aug 3, 2019

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Aug 2, 2019

PR description:

It was noticed in #27660 that ESInputTag parameters can not be added in fillDescriptions(). This PR adds the support.

PR validation:

Code compiles and unit tests succeed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The code-checks are being triggered in jenkins.

@makortel makortel force-pushed the parameterDescriptionESInputTag branch from 4f3c89c to d3b6963 Compare August 2, 2019 20:26
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27684/11280

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Integration
FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Aug 2, 2019

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1818/console Started: 2019/08/02 22:36

@makortel
Copy link
Contributor Author

makortel commented Aug 2, 2019

@wddgit Could you please take a look?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-481b82/1818/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2492470
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2492151
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 3, 2019

+1

@cmsbuild cmsbuild merged commit d40c1e5 into cms-sw:master Aug 3, 2019
@wddgit
Copy link
Contributor

wddgit commented Aug 5, 2019

@makortel I took a quick look at it. It all looks good. Thanks for taking care of it. I was on vacation Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants