Run3-TB42 Correct numbering for AHCal so that |row|/|column| can exceed 10

[bsunanda]

PR description:

The earlier code was restricting row-column number for AHCal cell to be within -9 to +9. In fact it has to be between -12 to +12. The code is corrected to allow that

PR validation:

Tested with scripts for TestBeam simulation

if this PR is a backport please specify the original PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27708/11327

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData
SimG4CMS/HGCalTestBeam

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1869/console Started: 2019/08/07 15:58

[cmsbuild]

+1
Tested at: 5d628ed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30dbf4/1869/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30dbf4/1869/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 2715989
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2715659
• DQMHistoTests: Total skipped: 329
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[civanch]

+1

[fabiocos]

+1

@kpedro88 this looks relatively simple to me

[cvuosalo]

These factors of 10 are magic numbers. The values in DDAHcalModuleAlgo.cc must match those in AHCalSD.cc for this code to work right. The best way to ensure that is for both files to use the same constants. Since this PR is bug fix, this issue doesn't need to be fixed now, but it would be good to clean it up eventually.

[fabiocos]

@cvuosalo I agree, on the other side this was the situation even before, I believe the adjustment using named constants can be factorized

[fabiocos]

merge

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.