Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new random service interface #2771

Merged
merged 1 commit into from
Mar 10, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Mar 7, 2014

Migrate the RandomFilter module to the new random
service interface designed for multithreading.

Migrate the RandomFilter module to the new random
service interface designed for multithreading.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X.

Migrate to new random service interface

It involves the following packages:

IOMC/RandomEngine

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

+1
@ktf This also seems like it should be generators and not core

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@wddgit
Copy link
Contributor Author

wddgit commented Mar 7, 2014

IOMC/RandomEngine is probably really a core package because it contains the random number service itself, used by simulation and generators and anything else using random numbers. The module which is changed is just used for some tests, and they are not generator tests. (For the other package though, I agree the ParticleGuns package ought to be in the generators category)

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 10, 2014
IOMC/RandomEngine -- Migrate to new random service interface
@nclopezo nclopezo merged commit 9ebb2a6 into cms-sw:CMSSW_7_1_X Mar 10, 2014
@wddgit wddgit deleted the migrateRandomFilter branch April 25, 2014 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants