Fix filling histograms in JetTester_HeavyIons #27720
Conversation
The gcc 9 compiler warned that case statements within a switch statement were 'falling through'. This meant on particle was filling histograms for hadrons, electrons, muons, etc. The code now contains the necessary 'break' statement.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27720/11340
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: Validation/RecoJets @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
+1 |
PR description:
The gcc 9 compiler warned that case statements within a switch statement were 'falling through'. This meant on particle was filling histograms for hadrons, electrons, muons, etc.
The code now contains the necessary 'break' statement.
PR validation:
The code compiles using a gcc 9 IB.
This is expected to fix filling of histograms from the JetTester_HeavyIons module.