Bug fix for 2016-2017 HBHE negative energy filter

[christopheralanwest]

PR description:

This PR fixes the misconfiguration of the HBHE noise filter in the 2016-2017 offline GT after migrating Mahi to use 8 samples rather than 10 [1].

This PR should be merged before PR #27644 so that the GT history in autoCond is consistent with that of the GT queues.

[1] https://indico.cern.ch/event/840252/#14-ultralegacy-2017-gt-fix-for

GT diffs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_2017_2018_Candidate_2019_08_03_03_51_45/110X_dataRun2_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_relval_Candidate_2019_08_03_03_55_32/110X_dataRun2_relval_v4

PR validation:

See [1] for details. A technical test was also performed: runTheMatrix.py -l limited -i all --ibeos

[1] https://indico.cern.ch/event/840252/#14-ultralegacy-2017-gt-fix-for

if this PR is a backport please specify the original PR:

This is not a backport.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27733/11364

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/AlCa/python/autoCond.py modified in PR(s): Phase-2 InnerTracker conditions from DB (version 2) #27517, enabling UL regression for 2018 (and likely Run3) #27644

[cmsbuild]

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1924/console Started: 2019/08/08 23:04

[cmsbuild]

+1
Tested at: bf1016e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d407cc/1924/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d407cc/1924/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2394 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 2715989
• DQMHistoTests: Total failures: 94
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 2715560
• DQMHistoTests: Total skipped: 329
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.098 KiB( 32 files compared)
• DQMHistoSizes: changed ( 136.788 ): 0.098 KiB JetMET/SUSYDQM
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[christopheralanwest]

+1

• payload validated with local tests
• PR comparison tests show only changes in 2016 and 2017 workflows, consistent with expectation

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1