Fixes for DDShapes to support DD4hep migration

[cvuosalo]

PR description:

This PR is a piece of #27674, which has been delayed. This PR has fixes for DDShapes classes. Conversions of angles from the degrees returned by DD4hep to the radians expected in CMS code are added. The DDTruncTubs class is corrected so that it returns correct values for its parameters.

For now, DDPseudoTrap is commented out as the need for this class is still under discussion.

PR validation:

This code was tested as described in #27674.

No backport is needed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27740/11377

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/interface/DDShapes.h modified in PR(s): Magnetic field geometry builder migration to DD4hep #27674
  • File DetectorDescription/DDCMS/src/DDShapes.cc modified in PR(s): Magnetic field geometry builder migration to DD4hep #27674

[cmsbuild]

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1941/console Started: 2019/08/09 19:41

[cmsbuild]

+1
Tested at: 1375abe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a3c04/1941/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a3c04/1941/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939165
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1