Scenario 2021, no overlaps for the Muon system in DD and DD4HEP geome… #27744

slomeo · 2019-08-11T15:42:13Z

…try, all MB4Shields included

PR description:

TestGeometry2021.py (for DD4HEP migration): ok (i.e No Overlaps for the Muon System as you can see in the attached picture)

All MP4 Shields for Scenario 2021 (2026) are ready (orange or red in the attached picture). They are made of different number of "tiles" with different dimensions, thickness and materials.

They are needed to perform MC studies of the Neutron Background (for Run3)

slomeo · 2019-08-11T15:42:54Z

cmsbuild · 2019-08-11T15:44:44Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-08-11T15:51:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27744/11385

This PR adds an extra 40KB to repository

cmsbuild · 2019-08-11T15:52:05Z

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/CMSCommonData
Geometry/MuonCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@ptcox, @vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

civanch · 2019-08-11T16:11:11Z

please test

cmsbuild · 2019-08-11T16:11:37Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1952/console Started: 2019/08/11 18:12

cmsbuild · 2019-08-11T17:41:46Z

+1
Tested at: c6b211f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32e01d/1952/summary.html

cmsbuild · 2019-08-11T17:41:49Z

Comparison job queued.

cmsbuild · 2019-08-11T19:18:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32e01d/1952/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2939508
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2939166
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 142 log files, 14 edm output root files, 34 DQM output files

ianna · 2019-08-11T20:39:08Z

Geometry/CMSCommonData/python/cmsExtendedGeometry2021XML_cfi.py

-        'Geometry/MuonCommonData/data/mb4/2015/v1/mb4.xml',
-        'Geometry/MuonCommonData/data/mb4Shield/2018/v1/mb4Shield.xml',
+        'Geometry/HcalCommonData/data/hcalRecNumbering/2021/hcalRecNumbering.xml',
+        'Geometry/MuonCommonData/data/mbCommon/2015/v3/mbCommon.xml',


it should probably be 2021/v1?

ianna · 2019-08-11T20:39:38Z

DetectorDescription/DDCMS/data/cms-geometry-2021.xml

@@ -46,8 +46,8 @@
    <Include ref='Geometry/CMSCommonData/data/cmsBeam/2026/v1/cmsBeam.xml'/>
    <Include ref='Geometry/CMSCommonData/data/muonMB.xml'/>
    <Include ref='Geometry/CMSCommonData/data/muonMagnet.xml'/>
-    <Include ref='Geometry/CMSCommonData/data/cavern/2018/v1/cavern.xml'/>
-    <Include ref='Geometry/CMSCommonData/data/cavernData/2017/v1/cavernData.xml'/>
+    <Include ref='Geometry/CMSCommonData/data/cavern/2018/v2/cavern.xml'/>


should it be 2021/v1?

Yes, it could be better. For both cavern files?

ianna · 2019-08-11T20:39:48Z

DetectorDescription/DDCMS/data/cms-geometry-2021.xml

-    <Include ref='Geometry/CMSCommonData/data/cavern/2018/v1/cavern.xml'/>
-    <Include ref='Geometry/CMSCommonData/data/cavernData/2017/v1/cavernData.xml'/>
+    <Include ref='Geometry/CMSCommonData/data/cavern/2018/v2/cavern.xml'/>
+    <Include ref='Geometry/CMSCommonData/data/cavernData/2017/v2/cavernData.xml'/>


ianna · 2019-08-11T20:40:02Z

DetectorDescription/DDCMS/data/cms-geometry-2021.xml

@@ -254,13 +254,13 @@
    <Include ref='Geometry/HcalCommonData/data/average/hcalforwardmaterial.xml'/>
    <Include ref='Geometry/HcalCommonData/data/hcalSimNumbering/2021/hcalSimNumbering.xml'/> 
    <Include ref='Geometry/HcalCommonData/data/hcalRecNumbering/2021/hcalRecNumbering.xml'/>
-    <Include ref='Geometry/MuonCommonData/data/mbCommon/2015/v2/mbCommon.xml'/>
+    <Include ref='Geometry/MuonCommonData/data/mbCommon/2015/v3/mbCommon.xml'/>


cmsbuild · 2019-08-12T16:03:31Z

Pull request #27744 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

fabiocos · 2019-08-12T16:07:48Z

please test

cmsbuild · 2019-08-12T16:08:30Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1974/console Started: 2019/08/12 18:10

cmsbuild · 2019-08-12T17:37:50Z

+1
Tested at: 5067b14
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32e01d/1974/summary.html

cmsbuild · 2019-08-12T17:37:53Z

Comparison job queued.

cmsbuild · 2019-08-12T19:57:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32e01d/1974/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2939508
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2939166
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 142 log files, 14 edm output root files, 34 DQM output files

ianna · 2019-08-12T20:24:01Z

+1

ianna · 2019-08-13T06:20:38Z

@kpedro88 - please review

fabiocos · 2019-08-13T13:27:19Z

@kpedro88 this looks ok to me
@ianna I assume a parallel DB update needs to be done, right?

ianna · 2019-08-13T15:18:57Z

@fabiocos - yes, @slomeo will take care of it. I think, he's already made a GT candidate queue.

slomeo · 2019-08-13T15:29:08Z

@ianna @fabiocos Yes, I have already made a "candidate"

Name: 106X_mcRun3_2021_realistic_Candidate_2019_08_12_09_16_22
From GT: 106X_mcRun3_2021_realistic_Queue
Scenario: RunIII Simulation
Workflow: Asymptotic Conditions
Release: CMSSW_10_6_X
Description: Candidate created from the queue: 106X_mcRun3_2021_realistic_Queue at: 2019-08-12 09:16:22
Snapshot Time: 2019-08-12 09:16:22
Validity: 18446744073709551615
Your added records:
    Record: GeometryFileRcd , Label: Extended2021 , Tag: XMLFILE_Geometry_110YV2_Extended2021_mc

fabiocos · 2019-08-13T20:05:49Z

+1

fabiocos · 2019-08-13T20:08:16Z

merge

kpedro88 · 2019-08-19T17:30:05Z

+upgrade

cmsbuild · 2019-08-19T17:30:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_11_0_X milestone Aug 11, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Aug 11, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 11, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 11, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 11, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 11, 2019

ianna reviewed Aug 11, 2019

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved comparison-available tests-approved labels Aug 12, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 12, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 12, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 12, 2019

cmsbuild added geometry-approved and removed geometry-pending labels Aug 12, 2019

cmsbuild added orp-approved and removed orp-pending labels Aug 13, 2019

cmsbuild merged commit 159e08b into cms-sw:master Aug 13, 2019

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Aug 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scenario 2021, no overlaps for the Muon system in DD and DD4HEP geome… #27744

Scenario 2021, no overlaps for the Muon system in DD and DD4HEP geome… #27744

slomeo commented Aug 11, 2019

slomeo commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

civanch commented Aug 11, 2019

cmsbuild commented Aug 11, 2019 •

edited

cmsbuild commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

ianna Aug 11, 2019

ianna Aug 11, 2019

slomeo Aug 11, 2019

ianna Aug 11, 2019

slomeo Aug 11, 2019

ianna Aug 11, 2019

slomeo Aug 11, 2019

cmsbuild commented Aug 12, 2019

fabiocos commented Aug 12, 2019

cmsbuild commented Aug 12, 2019 •

edited

cmsbuild commented Aug 12, 2019

cmsbuild commented Aug 12, 2019

cmsbuild commented Aug 12, 2019

ianna commented Aug 12, 2019

ianna commented Aug 13, 2019

fabiocos commented Aug 13, 2019

ianna commented Aug 13, 2019

slomeo commented Aug 13, 2019

fabiocos commented Aug 13, 2019

fabiocos commented Aug 13, 2019

kpedro88 commented Aug 19, 2019

cmsbuild commented Aug 19, 2019

Scenario 2021, no overlaps for the Muon system in DD and DD4HEP geome… #27744

Scenario 2021, no overlaps for the Muon system in DD and DD4HEP geome… #27744

Conversation

slomeo commented Aug 11, 2019

PR description:

slomeo commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

civanch commented Aug 11, 2019

cmsbuild commented Aug 11, 2019 • edited

cmsbuild commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

cmsbuild commented Aug 11, 2019

ianna Aug 11, 2019

Choose a reason for hiding this comment

ianna Aug 11, 2019

Choose a reason for hiding this comment

slomeo Aug 11, 2019

Choose a reason for hiding this comment

ianna Aug 11, 2019

Choose a reason for hiding this comment

slomeo Aug 11, 2019

Choose a reason for hiding this comment

ianna Aug 11, 2019

Choose a reason for hiding this comment

slomeo Aug 11, 2019

Choose a reason for hiding this comment

cmsbuild commented Aug 12, 2019

fabiocos commented Aug 12, 2019

cmsbuild commented Aug 12, 2019 • edited

cmsbuild commented Aug 12, 2019

cmsbuild commented Aug 12, 2019

cmsbuild commented Aug 12, 2019

ianna commented Aug 12, 2019

ianna commented Aug 13, 2019

fabiocos commented Aug 13, 2019

ianna commented Aug 13, 2019

slomeo commented Aug 13, 2019

fabiocos commented Aug 13, 2019

fabiocos commented Aug 13, 2019

kpedro88 commented Aug 19, 2019

cmsbuild commented Aug 19, 2019

cmsbuild commented Aug 11, 2019 •

edited

cmsbuild commented Aug 12, 2019 •

edited