-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply postEra customization for HI 2018 data #27755
Conversation
The code-checks are being triggered in jenkins. |
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27755/11418
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @prebello, @chayanit, @zhenhu, @kpedro88, @pgunnell can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Thank you for prompt fix, Slava. |
Comparison job queued. |
please test workflow 140.56,140.57 |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
Comparison is ready Comparison Summary:
|
Additionally, the following warning disappeared from the logs of the 2018 data HI workflow 140.56 (this is expected)
|
there is no conflict with #27727 so they can be both merged in next IB without issues |
+1 |
merge |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
RecoTLR.customisePostEra_
should be present for all data reprocessing in order to match the settings used in the prompt reco.I tested on 200 events in wf 140.56 and there were no differences. The effect is apparently small.
@abdoulline @jaehyeok