-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCal] Validation: Increase the score for matching Layerclusters and CaloParticles #27775
Conversation
The code-checks are being triggered in jenkins. |
@rovere fyi |
@apsallid fyi |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27775/11454
|
A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master. It involves the following packages: Validation/HGCalValidation @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
LayerClusters and Caloparticles are matched if the validation score [0] is lower than a threshold.
With this PR we increase that threshold from 0.01 to 0.1 which is, by looking at the distributions of the scores a more appropriate value.
It would be nice to have this before 11_0_0 is closed.
[0]http://hgcal.web.cern.ch/hgcal/Validation/LayerClusterValidation/