-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geant4 parameters for tracking in field #27789
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27789/11477
|
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@civanch comparing performance differences in the JobReport for 11634.0 vs to the baseline does not show very significant changes, that can be trusted on such a small statistics. Which kind of effect would you expect? The maximum step size is reduced, so I would expect on average a bit more steps... |
+1 |
@fabiocos , I would expect more number of steps in vacuum and in air, in particular, less number of circles from low energy looping e+-. For example, before this PR geometry step limitation inside CMS vacuum tube is up to 3 m. |
PR description:
For a long time non-optimal parameters for Geant4 tracking in field were used in order do not change simulation histories and not redo full validation for UL. In this PR few CMS/G4 magnetic field parameters are change, that will provoke many differences in regression. The CPU effects is expected to be minor, number of warnings from Geant4 tracking in field should be reduced dramatically. This seems to be useful for deployment of the coming Geant4 10.6.
PR validation:
private
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: