Add Skewed Phase 2 Inner Tracker geometry (T16). #27824

ghugo83 · 2019-08-22T14:44:32Z

PR description:

This PR adds Skewed Phase 2 Inner Tracker geometry (T16), and its associated workflows.
The skewed Inner Tracker description is accessible at: http://cms-tklayout.web.cern.ch/cms-tklayout/layouts-work/repository-git-dev/OT616_200_IT613/layoutpixel.html

Several ladders are rotated in TBPX around CMX_Z axis ('skewed'). This is to allow space for cooling pipes, as it will be in the detector to be installed.
There is no update in terms of Material Budget here, focus is geometry-only.

Geometry scenario is: 2026D48.
Workflows are: 228xx (no PU), 230xx (PU).

Tracking performance should be compared with T15 (2026D46 scenario).

NB:

Please merge PR Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665 first.
Present PR is created on top of 27665, to avoid having shifts in workflow numbering (no need to leave free spots for D47).
I (might) have very trivial conflict to solve once 27665 is merged into master.
IMPORTANT: This only introduces the skewed geometry description. There might be adjustments to do on CMSSW side to deal with the skewed ladders.
Got runs through the 4 steps without extra warning/error, which is already a good sign, but obviously does not mean at all everything is OK...
On CMSSW side, I checked that the sim geometry construction is OK.
First feedback from @migliore is that DIGI step should be fine, this should be looked at in details though.
Possible tunings needed on top of this PR!

PR validation:
Following was done for validation:

Solved all overlaps on CMSSW with Fireworks and Geant4 tools.
Checked sim geometry construction is OK on CMSSW side.
Even if the active geometry is different from T15, logically there should be no DetId diff (based on how the DetIds are computed in CMSSW). Checked that this is the case indeed.
This allows to reuse the fakeConditions from T15.
Checked no shift in workflows numbering.
Checked that workflows with D48 run smoothly with no extra error / warning.

FYI: @emiglior @pwittich @bsunanda @fabiocos @kpedro88 @mmusich @jalimena @boudoul

…uding HFNose

… from bsunanda to avoid issues in workflow numbering.

…n D47.

…the latest CMS geometries. Hence, D48 is now same as D47, but with Tracker T16 instead of T15.

cmsbuild · 2019-08-22T14:45:06Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-08-22T14:50:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27824/11548

This PR adds an extra 80KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Eras/python/Era_Phase2C10_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Eras/python/Era_Phase2C10_timing_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Eras/python/Era_Phase2C10_timing_layer_bar_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Geometry/README.md modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Geometry/python/GeometryExtended2026D47Reco_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Geometry/python/GeometryExtended2026D47_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/PyReleaseValidation/python/relval_2026.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): NanoAOD step added in upgrade 2017 samples #27806, Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665, Add combined premixing workflows for Run 3 #27753
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Complete the implementation of RPC Digi Collection Merger started in PR #24613 #27672, Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/StandardSequences/python/GeometryConf.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Geometry/CMSCommonData/python/cmsExtendedGeometry2026D47XML_cfi.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665

cmsbuild · 2019-08-22T14:51:07Z

A new Pull Request was created by @ghugo83 for master.

It involves the following packages:

Configuration/Eras
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData

@cmsbuild, @prebello, @Dr15Jones, @chayanit, @cvuosalo, @civanch, @ianna, @mdhildreth, @pgunnell, @franzoni, @kpedro88, @zhenhu, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2019-08-22T15:21:06Z

Configuration/Geometry/README.md

@@ -37,5 +39,7 @@ Several detector combinations have been generated:
 * D44 = T14+C6+M3+I7+O2+F3
 * D45 = T15+C8+M3+I10+O3+F2
 * D46 = T15+C9+M3+I10+O3+F2
+* D47 = T15+C10+M3+I10+O3+F3
+* D48 = T16+C10+M3+I10+O3+F3


I don't think a tracker test workflow needs to include the HF nose. I would make either D45 or D46 the basis for D48.

Are C10 and F3 not the latest descriptions available?
In that case, why not having the latest Tracker description with them, and compare D48 versus D47?
It would avoid having latest subdetectorA with old subdetectorB and latest subdetectorB with old subdetectorA. Which would imply that when one wants to access the latest available CMS geometry, it does not exist?

C10 and F3 are the latest version of the HF nose. This is a detector R&D effort that is not yet an approved part of the Phase 2 upgrade project. Combining tracker tests with this will just lead to confusion and inconsistencies.

Ha I didn't know C10 and F3 were purely in an hypothetical state for now.
Ok I will simply revert my last commit then.

… of T15.

cmsbuild · 2019-08-22T16:53:28Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-08-22T16:59:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27824/11555

This PR adds an extra 76KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Eras/python/Era_Phase2C10_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Eras/python/Era_Phase2C10_timing_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Eras/python/Era_Phase2C10_timing_layer_bar_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Geometry/README.md modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Geometry/python/GeometryExtended2026D47Reco_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Geometry/python/GeometryExtended2026D47_cff.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/PyReleaseValidation/python/relval_2026.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): NanoAOD step added in upgrade 2017 samples #27806, Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665, Add combined premixing workflows for Run 3 #27753
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Complete the implementation of RPC Digi Collection Merger started in PR #24613 #27672, Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Configuration/StandardSequences/python/GeometryConf.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665
- File Geometry/CMSCommonData/python/cmsExtendedGeometry2026D47XML_cfi.py modified in PR(s): Phase2-hcx214 Add a new scenario and workflow with latest Phase2 configuration including HFNose #27665

cmsbuild · 2019-08-26T21:55:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-615495/2193/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-615495/22834.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D48_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D48+RecoFullGlobal_2026D48+HARVESTFullGlobal_2026D48

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2939508
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2939166
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 145 log files, 15 edm output root files, 34 DQM output files

cvuosalo · 2019-08-27T20:28:59Z

+1

kpedro88 · 2019-08-27T23:36:53Z

@ghugo83 @mmusich please comment on the GT for the new tracker geometry

mmusich · 2019-08-28T07:05:51Z

@kpedro88 as stated in the PR description:

Even if the active geometry is different from T15, logically there should be no DetId diff (based on how the DetIds are computed in CMSSW). Checked that this is the case indeed.
This allows to reuse the fakeConditions from T15.

This means that using auto:phase2_realistic_T15 is OK.

kpedro88 · 2019-08-28T14:19:35Z

+upgrade

kpedro88 · 2019-08-28T14:19:47Z

+operations

kpedro88 · 2019-08-30T13:42:35Z

@prebello, @chayanit, @pgunnell, @zhenhu please sign

chayanit · 2019-08-30T13:58:51Z

+1

cmsbuild · 2019-08-30T13:59:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

kpedro88 · 2019-08-30T21:02:43Z

+1

Sunanda and others added 7 commits August 2, 2019 18:25

Add a new scenario and workflow with latest Phase2 configuration incl…

d89e73b

…uding HFNose

Change cfi file due to change in muon system

793b2e3

XML: Add Phase 2 Skewed Inner Tracker geometry.

131c629

Geometry scenario: Add D48. Same as D46 but with Tracker T16.

79de561

Workflows: add workflows associated to D48. Will need to merge branch…

724213f

… from bsunanda to avoid issues in workflow numbering.

Merged bsunanda:Phase2-hcx214 + Fixed merge conflict + Corrected GT i…

b245d6b

…n D47.

Geometry scenario: Update D48. It is better to have D48 based on all …

ce63120

…the latest CMS geometries. Hence, D48 is now same as D47, but with Tracker T16 instead of T15.

cmsbuild added this to the CMSSW_11_0_X milestone Aug 22, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Aug 22, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 22, 2019

kpedro88 reviewed Aug 22, 2019

View reviewed changes

Revert ce63120. D48 is now based on D46, but with Tracker T16 instead…

0ecac76

… of T15.

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 22, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 22, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 26, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 26, 2019

cmsbuild mentioned this pull request Aug 26, 2019

Magnetic field geometry builder migration to DD4hep #27674

Closed

cmsbuild added geometry-approved and removed geometry-pending labels Aug 27, 2019

cmsbuild added operations-approved upgrade-approved and removed operations-pending upgrade-pending labels Aug 28, 2019

This was referenced Aug 28, 2019

Add EDProducers for mkFit #27895

Merged

HGCAL: 1st version of hadronic reconstruction #27819

Merged

cmsbuild added fully-signed pdmv-approved and removed pdmv-pending pending-signatures labels Aug 30, 2019

cmsbuild added orp-approved and removed orp-pending labels Aug 30, 2019

cmsbuild merged commit d0001ef into cms-sw:master Aug 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Skewed Phase 2 Inner Tracker geometry (T16). #27824

Add Skewed Phase 2 Inner Tracker geometry (T16). #27824

ghugo83 commented Aug 22, 2019 •

edited

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

kpedro88 Aug 22, 2019

ghugo83 Aug 22, 2019 •

edited

kpedro88 Aug 22, 2019

ghugo83 Aug 22, 2019 •

edited

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 26, 2019

cvuosalo commented Aug 27, 2019

kpedro88 commented Aug 27, 2019

mmusich commented Aug 28, 2019

kpedro88 commented Aug 28, 2019

kpedro88 commented Aug 28, 2019

kpedro88 commented Aug 30, 2019

chayanit commented Aug 30, 2019

cmsbuild commented Aug 30, 2019

kpedro88 commented Aug 30, 2019

Add Skewed Phase 2 Inner Tracker geometry (T16). #27824

Add Skewed Phase 2 Inner Tracker geometry (T16). #27824

Conversation

ghugo83 commented Aug 22, 2019 • edited

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

kpedro88 Aug 22, 2019

Choose a reason for hiding this comment

ghugo83 Aug 22, 2019 • edited

Choose a reason for hiding this comment

kpedro88 Aug 22, 2019

Choose a reason for hiding this comment

ghugo83 Aug 22, 2019 • edited

Choose a reason for hiding this comment

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 22, 2019

cmsbuild commented Aug 26, 2019

cvuosalo commented Aug 27, 2019

kpedro88 commented Aug 27, 2019

mmusich commented Aug 28, 2019

kpedro88 commented Aug 28, 2019

kpedro88 commented Aug 28, 2019

kpedro88 commented Aug 30, 2019

chayanit commented Aug 30, 2019

cmsbuild commented Aug 30, 2019

kpedro88 commented Aug 30, 2019

ghugo83 commented Aug 22, 2019 •

edited

ghugo83 Aug 22, 2019 •

edited

ghugo83 Aug 22, 2019 •

edited