Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgc slhc8 #2786

Merged
merged 5 commits into from Mar 10, 2014
Merged

Hgc slhc8 #2786

merged 5 commits into from Mar 10, 2014

Conversation

pfs
Copy link
Contributor

@pfs pfs commented Mar 10, 2014

(now with the correct target set...)
This includes some developments for HGCal simulation

Decreasing e/gamma range cuts for HGC simulation
Factorized sim hits according to sub-detector type
Lateral segmentation in HE increased to 10cm^2
Renaming HGC DetId methods consistently

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC.

Hgc slhc8

It involves the following packages:

DataFormats/ForwardDetId
Geometry/HGCalSimData
SimG4CMS/Calo

The following packages do not have a category, yet:

DataFormats/ForwardDetId
Geometry/HGCalSimData

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.

cmsbuild added a commit that referenced this pull request Mar 10, 2014
@cmsbuild cmsbuild merged commit 0d50887 into cms-sw:CMSSW_6_2_X_SLHC Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants