Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the TEC mod from Adrian Perieanu to the test2014 folder #2794

Merged
merged 1 commit into from
Mar 12, 2014

Conversation

GiacomoSguazzoni
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @GiacomoSguazzoni for CMSSW_7_1_X.

Adding the TEC mod from Adrian Perieanu to the test2014 folder

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@@ -894,7 +894,7 @@
<rMaterial name="trackermaterial:T_CarbonFibreStr" />
</MaterialFraction>
</CompositeMaterial>
<CompositeMaterial name="TEC_PatchpanelBox" density="2.669*g/cm3" method="mixture by weight" symbol=" ">
<CompositeMaterial density="2.669*0.79*g/cm3" method="mixture by weight" name="TEC_PatchpanelBox" symbol=" ">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiacomoSguazzoni - I think, keeping the attribute order is important.

@civanch
Copy link
Contributor

civanch commented Mar 11, 2014

I would also agree that there is no sense to change order of parameters, because this introduces extra mess. It may be that xml parser resolve the situation and can read these lines but these files are less readable, so it is not good for maintenance.

@ianna
Copy link
Contributor

ianna commented Mar 11, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 12, 2014
Geometry -- Adding the TEC mod from Adrian Perieanu to the test2014 folder
@ktf ktf merged commit 84658f9 into cms-sw:CMSSW_7_1_X Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants