fix mistaken dims & pos of me11 gas vols #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @ptcox for CMSSW_7_1_X. fix mistaken dims & pos of me11 gas vols It involves the following packages: Geometry/MuonCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks. |
|
+1 |
nclopezo
added a commit
that referenced
this pull request
Mar 11, 2014
Geometry/MuonCommonData -- fix mistaken dims & pos of me11 gas vols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last attempt to correct ME11 ActiveGasVol dimensions (where simhits are produced) failed because the centres of ME11A and ME11B had been originally positioned too close together and I caused the volumes to overlap. This resets those positions correctly, and updates the lengths of each volume. This time I checked for overlaps using the Fireworks overlap tool (Thanks, Yana) and this time there are no overlaps dues to my changes.