option to use fake vertex in GlobalTrackingRegionWithVerticesProducer

[olivito]

Adds an option to allow use of fake vertices in GlobalTrackingRegionWithVerticesProducer. The use case is for the HLT to create a tracking region using a fake vertex with the Z0 of a lepton.

The option is turned off by default to preserve the existing behavior.

[cmsbuild]

A new Pull Request was created by @olivito (Dominick Olivito) for CMSSW_7_1_X.

option to use fake vertex in GlobalTrackingRegionWithVerticesProducer

It involves the following packages:

RecoTracker/TkTrackingRegions

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @gpetruc, @GiacomoSguazzoni, @rovere, @cerati this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 11-Mar-2014 11:40:22 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PixelTrackProducer label='hltFastPVPixelTracks'
Exception Message:
MissingParameter: Parameter 'useFakeVertices' not found.
----- End Fatal Exception -------------------------------------------------

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 11-Mar-2014 11:42:17 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PixelTrackProducer label='hltFastPVPixelTracks'
Exception Message:
MissingParameter: Parameter 'useFakeVertices' not found.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 11-Mar-2014 11:43:22 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PixelTrackProducer label='hltFastPVPixelTracks'
Exception Message:
MissingParameter: Parameter 'useFakeVertices' not found.
----- End Fatal Exception -------------------------------------------------

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 11-Mar-2014 11:51:15 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PixelTrackProducer label='hltFastPVPixelTracks'
Exception Message:
MissingParameter: Parameter 'useFakeVertices' not found.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2797/433/summary.html

[olivito]

@Martin-Grunewald, @perrotta

It looks like this parameter will have to be added in ConfDB to have this PR go through.

[perrotta]

Hi Dominick.

In order to avoid this PR crashing AND to allow backward compatibility
you should check instead the existence of the newly added parameter
with the usual existsAs<> method, and define some default value for it
in case it does not exist. Such a default parameters should reproduce
the old behaviour. Then the new one will be implemented in the HLT
development menu via ConfDB, and not in the frozen one, once approved
by TSG.

Andrea

Dominick Olivito notifications@github.com ha scritto:

@Martin-Grunewald, @perrotta

It looks like this parameter will have to be added in ConfDB to have
this PR go through.

---

Reply to this email directly or view it on GitHub:
#2797 (comment)

---

This message was sent using IMP, the Internet Messaging Program.

[olivito]

Thanks Andrea. I've used existsAs<> to provide a default value for backward compatibility. I tested locally with runTheMatrix.py, and it ran without issues.

I don't know if the new commit will trigger the automatic tests again - if not could somebody please queue them again?

[cmsbuild]

Pull request #2797 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

[nclopezo]

Hi,

I queued them again.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2797/440/summary.html

[slava77]

+1

for #2797 0eac859
jenkins ok

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?