Don't look at base classes of STL containers #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X. Don't look at base classes of STL containers It involves the following packages: CondCore/ORA @ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks. |
davidlt
added a commit
that referenced
this pull request
Mar 10, 2014
Don't look at base classes of STL containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a segfault that is now causing many relvals in the ROOT6 IB to fail.
The conditions code searches for base classes of each class that is used in conditions, and attempts to construct a TypeWithDict from the base class. However, if the class in question is an instance of an STL container, the base classes, if any, do not have dictionaries, and a segfault results due to a null pointer dereference.
This pull request simply suppresses the search for base classes of STL containers. This search was unnecessary anyway, since ROOT understands STL containers.